From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 3/9] vl: Fail right after first bad -object
Date: Mon, 8 Jun 2015 20:02:11 +0200 [thread overview]
Message-ID: <1433786537-30874-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1433786537-30874-1-git-send-email-armbru@redhat.com>
Failure to create an object with -object is a fatal error. However,
we delay the actual exit until all -object are processed. On the one
hand, this permits detection of genuine additional errors. On the
other hand, it can muddy the waters with uninteresting additional
errors, e.g. when a later -object tries to reference a prior one that
failed.
We generally stop right on the first bad option, so do that for
-object as well.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 680f4d8..c9c3f33 100644
--- a/vl.c
+++ b/vl.c
@@ -4055,7 +4055,7 @@ int main(int argc, char **argv, char **envp)
}
if (qemu_opts_foreach(qemu_find_opts("object"),
- object_create, NULL, 0) != 0) {
+ object_create, NULL, 1) != 0) {
exit(1);
}
--
1.9.3
next prev parent reply other threads:[~2015-06-08 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 18:02 [Qemu-devel] [PULL 0/9] Error reporting patches Markus Armbruster
2015-06-08 18:02 ` [Qemu-devel] [PULL 1/9] vl: Report failure to sandbox at most once Markus Armbruster
2015-06-08 18:02 ` [Qemu-devel] [PULL 2/9] vl: Print -device help " Markus Armbruster
2015-06-08 18:02 ` Markus Armbruster [this message]
2015-06-08 18:02 ` [Qemu-devel] [PULL 4/9] QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure Markus Armbruster
2015-06-08 18:02 ` [Qemu-devel] [PULL 5/9] QemuOpts: Convert qemu_opts_foreach() to Error Markus Armbruster
2015-06-08 18:02 ` [Qemu-devel] [PULL 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach() Markus Armbruster
2015-06-08 18:02 ` [Qemu-devel] [PULL 7/9] QemuOpts: Drop qemu_opt_foreach() parameter abort_on_failure Markus Armbruster
2015-06-08 18:02 ` [Qemu-devel] [PULL 8/9] QemuOpts: Convert qemu_opt_foreach() to Error Markus Armbruster
2015-06-08 18:02 ` [Qemu-devel] [PULL 9/9] vhost-user: Improve -netdev/netdev_add/-net/... error reporting Markus Armbruster
2015-06-08 18:52 ` [Qemu-devel] [PULL 0/9] Error reporting patches Peter Maydell
2015-06-09 5:47 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433786537-30874-4-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).