From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z21NR-0007B9-3l for qemu-devel@nongnu.org; Mon, 08 Jun 2015 14:02:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z21NN-0008V3-Uk for qemu-devel@nongnu.org; Mon, 08 Jun 2015 14:02:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z21NN-0008UM-Pw for qemu-devel@nongnu.org; Mon, 08 Jun 2015 14:02:21 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 73439BF9D6 for ; Mon, 8 Jun 2015 18:02:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-59.ams2.redhat.com [10.36.116.59]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t58I2IK4008654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 8 Jun 2015 14:02:20 -0400 From: Markus Armbruster Date: Mon, 8 Jun 2015 20:02:11 +0200 Message-Id: <1433786537-30874-4-git-send-email-armbru@redhat.com> In-Reply-To: <1433786537-30874-1-git-send-email-armbru@redhat.com> References: <1433786537-30874-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PULL 3/9] vl: Fail right after first bad -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Failure to create an object with -object is a fatal error. However, we delay the actual exit until all -object are processed. On the one hand, this permits detection of genuine additional errors. On the other hand, it can muddy the waters with uninteresting additional errors, e.g. when a later -object tries to reference a prior one that failed. We generally stop right on the first bad option, so do that for -object as well. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 680f4d8..c9c3f33 100644 --- a/vl.c +++ b/vl.c @@ -4055,7 +4055,7 @@ int main(int argc, char **argv, char **envp) } if (qemu_opts_foreach(qemu_find_opts("object"), - object_create, NULL, 0) != 0) { + object_create, NULL, 1) != 0) { exit(1); } -- 1.9.3