From: "Gabriel L. Somlo" <somlo@cmu.edu>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, gsomlo@gmail.com, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series
Date: Mon, 8 Jun 2015 14:10:43 -0400 [thread overview]
Message-ID: <1433787045-6215-1-git-send-email-somlo@cmu.edu> (raw)
The fw_cfg cleanup series exposed a memory leak occurring on ppc and sparc
machine types.
This series adds a safe fw_cfg integer-type update function (1/2), and
modifies ppc and sparc callbacks to use it instead of the current leaky
method (2/2).
This should preferably go in *before* "fw_cfg: remove support for guest-side data writes", which would otherwise cause certain ppc and sparc command
lines to crash.
Once these are reviewed (also, see additional questions in 1/1), should I
re-spin the whole set, or keep these two as a separate, independent series?
Thanks,
Gabriel
Gabriel L. Somlo (2):
fw_cfg: add fw_cfg_modify_i16 (update) method
fw_cfg: fix FW_CFG_BOOT_DEVICE value update on ppc and sparc[64]
hw/nvram/fw_cfg.c | 10 ++++++++++
hw/ppc/mac_newworld.c | 2 +-
hw/ppc/mac_oldworld.c | 2 +-
hw/sparc/sun4m.c | 2 +-
hw/sparc64/sun4u.c | 2 +-
include/hw/nvram/fw_cfg.h | 1 +
6 files changed, 15 insertions(+), 4 deletions(-)
--
2.1.0
next reply other threads:[~2015-06-08 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 18:10 Gabriel L. Somlo [this message]
2015-06-08 18:10 ` [Qemu-devel] [PATCH 1/2] fw_cfg: add fw_cfg_modify_i16 (update) method Gabriel L. Somlo
2015-06-08 18:26 ` Gabriel L. Somlo
2015-06-09 8:14 ` Gerd Hoffmann
2015-06-08 18:10 ` [Qemu-devel] [PATCH 2/2] fw_cfg: fix FW_CFG_BOOT_DEVICE update on ppc and sparc Gabriel L. Somlo
2015-06-09 8:15 ` [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433787045-6215-1-git-send-email-somlo@cmu.edu \
--to=somlo@cmu.edu \
--cc=gsomlo@gmail.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).