From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, afaerber@suse.de, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 6/7] qdev-monitor: Propagate errors through set_property()
Date: Mon, 8 Jun 2015 20:57:56 +0200 [thread overview]
Message-ID: <1433789877-6950-7-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1433789877-6950-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qdev-monitor.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index f8876ef..01ea919 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -156,8 +156,7 @@ static int set_property(void *opaque, const char *name, const char *value,
object_property_parse(obj, value, name, &err);
if (err != NULL) {
- qerror_report_err(err);
- error_free(err);
+ error_propagate(errp, err);
return -1;
}
return 0;
@@ -592,7 +591,8 @@ DeviceState *qdev_device_add(QemuOpts *opts)
}
/* set properties */
- if (qemu_opt_foreach(opts, set_property, dev, NULL)) {
+ if (qemu_opt_foreach(opts, set_property, dev, &err)) {
+ qerror_report_err(err);
object_unparent(OBJECT(dev));
object_unref(OBJECT(dev));
return NULL;
--
1.9.3
next prev parent reply other threads:[~2015-06-08 18:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 18:57 [Qemu-devel] [PATCH 0/7] qdev: Mostly wean off QError Markus Armbruster
2015-06-08 18:57 ` [Qemu-devel] [PATCH 1/7] qdev: Deprecated qdev_init() is finally unused, drop Markus Armbruster
2015-06-08 19:03 ` Eric Blake
2015-06-08 18:57 ` [Qemu-devel] [PATCH 2/7] qdev: Un-deprecate qdev_init_nofail() Markus Armbruster
2015-06-08 19:12 ` Eric Blake
2015-06-08 18:57 ` [Qemu-devel] [PATCH 3/7] qdev-monitor: Stop error avalance in qbus_find_recursive() Markus Armbruster
2015-06-08 19:35 ` Eric Blake
2015-06-08 18:57 ` [Qemu-devel] [PATCH 4/7] qdev-monitor: Fix check for full bus Markus Armbruster
2015-06-08 19:39 ` Eric Blake
2015-06-08 18:57 ` [Qemu-devel] [PATCH 5/7] qdev-monitor: Convert qbus_find() to Error Markus Armbruster
2015-06-08 19:53 ` Eric Blake
2015-06-09 6:07 ` Markus Armbruster
2015-06-08 18:57 ` Markus Armbruster [this message]
2015-06-08 19:56 ` [Qemu-devel] [PATCH 6/7] qdev-monitor: Propagate errors through set_property() Eric Blake
2015-06-08 18:57 ` [Qemu-devel] [PATCH 7/7] qdev-monitor: Propagate errors through qdev_device_add() Markus Armbruster
2015-06-08 20:04 ` Eric Blake
2015-06-09 6:12 ` Markus Armbruster
2015-06-09 10:54 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433789877-6950-7-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).