From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z23Jc-00032M-J8 for qemu-devel@nongnu.org; Mon, 08 Jun 2015 16:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z23JZ-0002DL-6B for qemu-devel@nongnu.org; Mon, 08 Jun 2015 16:06:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z23JZ-0002Ce-0z for qemu-devel@nongnu.org; Mon, 08 Jun 2015 16:06:33 -0400 Message-ID: <1433793991.4927.75.camel@redhat.com> From: Alex Williamson Date: Mon, 08 Jun 2015 14:06:31 -0600 In-Reply-To: References: <20150608170543.5497.53497.stgit@gimli.home> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/3] Initial vfio-platform support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Eric Auger On Mon, 2015-06-08 at 18:50 +0100, Peter Maydell wrote: > On 8 June 2015 at 18:06, Alex Williamson wrote: > > The following changes since commit 2e29dd7c44db30e3d3c108ab2a622cbdac6d16f0: > > > > Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into staging (2015-06-08 14:07:32 +0100) > > > > are available in the git repository at: > > > > > > git://github.com/awilliam/qemu-vfio.git tags/vfio-update-20150608.0 > > > > for you to fetch changes up to 88be7b6bf4c86d89e70585881b6b3326f9bac822: > > > > hw/vfio/platform: calxeda xgmac device (2015-06-08 09:25:26 -0600) > > > > ---------------------------------------------------------------- > > Initial VFIO platform device support (Eric Auger, et al.) > > > > ---------------------------------------------------------------- > > Eric Auger (3): > > hw/vfio/platform: vfio-platform skeleton > > hw/vfio/platform: add irq assignment > > hw/vfio/platform: calxeda xgmac device > > Hi. I'm afraid this doesn't build with clang: > CC m68k-softmmu/hw/virtio/vhost.o > /home/petmay01/linaro/qemu-for-merges/hw/vfio/calxeda-xgmac.c:26:33: > error: unused variable > 'vfio_platform_vmstate' [-Werror,-Wunused-const-variable] > static const VMStateDescription vfio_platform_vmstate = { > ^ > > Clang is pickier about some kinds of unused variable, and this > looks like a genuine bug -- you haven't actually connected the > VMStateDescription up to anything. Thanks, Peter. Eric, it looks like you meant to set dc->vmsd to the address of this struct in the class init function. Do you want to fix that and I'll send a new pull request? I'd just send a new version of patch 3 with the fix rolled in. Thanks, Alex