From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2Eg3-0000bw-UO for qemu-devel@nongnu.org; Tue, 09 Jun 2015 04:14:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2Efz-0001c3-OR for qemu-devel@nongnu.org; Tue, 09 Jun 2015 04:14:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2Efz-0001bP-Iu for qemu-devel@nongnu.org; Tue, 09 Jun 2015 04:14:27 -0400 Message-ID: <1433837661.26677.1.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 09 Jun 2015 10:14:21 +0200 In-Reply-To: <20150608182630.GH32650@HEDWIG.INI.CMU.EDU> References: <1433787045-6215-1-git-send-email-somlo@cmu.edu> <1433787045-6215-2-git-send-email-somlo@cmu.edu> <20150608182630.GH32650@HEDWIG.INI.CMU.EDU> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] fw_cfg: add fw_cfg_modify_i16 (update) method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: peter.maydell@linaro.org, "Gabriel L. Somlo" , qemu-devel@nongnu.org On Mo, 2015-06-08 at 14:26 -0400, Gabriel L. Somlo wrote: > On Mon, Jun 08, 2015 at 02:10:44PM -0400, Gabriel L. Somlo wrote: > > Allow the ability to modify the value of an existing 16-bit integer > > fw_cfg item. > > > > Signed-off-by: Gabriel Somlo > > --- > > > > Couple of thoughts: > > > > 1. I'm thinking about pre-emptively creating _i16, _i32, and _i64 > > versions, but right now (for fixing sparc and ppc) we only need > > the _i16 version. What to do ? > > Presumably, I'll update the documentation to mention these update > functions as well (one more reason to do all three versions rather > than just _i16) :) Should be easy to add this once they are actually needed. Documentation update is fine, can go incremental though. cheers, Gerd