From: Gerd Hoffmann <kraxel@redhat.com>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: peter.maydell@linaro.org, gsomlo@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series
Date: Tue, 09 Jun 2015 10:15:45 +0200 [thread overview]
Message-ID: <1433837745.26677.3.camel@redhat.com> (raw)
In-Reply-To: <1433787045-6215-1-git-send-email-somlo@cmu.edu>
On Mo, 2015-06-08 at 14:10 -0400, Gabriel L. Somlo wrote:
> The fw_cfg cleanup series exposed a memory leak occurring on ppc and sparc
> machine types.
>
> This series adds a safe fw_cfg integer-type update function (1/2), and
> modifies ppc and sparc callbacks to use it instead of the current leaky
> method (2/2).
>
> This should preferably go in *before* "fw_cfg: remove support for guest-side data writes", which would otherwise cause certain ppc and sparc command
> lines to crash.
>
> Once these are reviewed (also, see additional questions in 1/1), should I
> re-spin the whole set, or keep these two as a separate, independent series?
Keeping separate is fine, I'll order the patches via 'git rebase'.
cheers,
Gerd
prev parent reply other threads:[~2015-06-09 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 18:10 [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series Gabriel L. Somlo
2015-06-08 18:10 ` [Qemu-devel] [PATCH 1/2] fw_cfg: add fw_cfg_modify_i16 (update) method Gabriel L. Somlo
2015-06-08 18:26 ` Gabriel L. Somlo
2015-06-09 8:14 ` Gerd Hoffmann
2015-06-08 18:10 ` [Qemu-devel] [PATCH 2/2] fw_cfg: fix FW_CFG_BOOT_DEVICE update on ppc and sparc Gabriel L. Somlo
2015-06-09 8:15 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433837745.26677.3.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=gsomlo@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).