From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2EhN-0001at-9d for qemu-devel@nongnu.org; Tue, 09 Jun 2015 04:15:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2EhI-00032V-Uo for qemu-devel@nongnu.org; Tue, 09 Jun 2015 04:15:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2EhI-00031u-Je for qemu-devel@nongnu.org; Tue, 09 Jun 2015 04:15:48 -0400 Message-ID: <1433837745.26677.3.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 09 Jun 2015 10:15:45 +0200 In-Reply-To: <1433787045-6215-1-git-send-email-somlo@cmu.edu> References: <1433787045-6215-1-git-send-email-somlo@cmu.edu> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] fw_cfg: *prequel* to cleanup series List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: peter.maydell@linaro.org, gsomlo@gmail.com, qemu-devel@nongnu.org On Mo, 2015-06-08 at 14:10 -0400, Gabriel L. Somlo wrote: > The fw_cfg cleanup series exposed a memory leak occurring on ppc and sparc > machine types. > > This series adds a safe fw_cfg integer-type update function (1/2), and > modifies ppc and sparc callbacks to use it instead of the current leaky > method (2/2). > > This should preferably go in *before* "fw_cfg: remove support for guest-side data writes", which would otherwise cause certain ppc and sparc command > lines to crash. > > Once these are reviewed (also, see additional questions in 1/1), should I > re-spin the whole set, or keep these two as a separate, independent series? Keeping separate is fine, I'll order the patches via 'git rebase'. cheers, Gerd