From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2Fa3-0000Rs-Gz for qemu-devel@nongnu.org; Tue, 09 Jun 2015 05:12:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2Fa0-0006ED-Bg for qemu-devel@nongnu.org; Tue, 09 Jun 2015 05:12:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2Fa0-0006DM-5n for qemu-devel@nongnu.org; Tue, 09 Jun 2015 05:12:20 -0400 Message-ID: <1433841137.26677.15.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 09 Jun 2015 11:12:17 +0200 In-Reply-To: <1433839784-5634-1-git-send-email-fziglio@redhat.com> References: <1433839784-5634-1-git-send-email-fziglio@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] RFC: qxl: allow to specify head limit to qxl driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frediano Ziglio Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org On Di, 2015-06-09 at 09:49 +0100, Frediano Ziglio wrote: > This patch allow to limit number of heads using qxl driver. By default > qxl driver is not limited on any kind on head use so can decide to use > as much heads. There is a hard limit of 16 monitors in the qxl device ... > Main question and stop over are parameter name. max_outputs please, to be consistent with upcoming virtio-vga. > + if (d->max_heads && d->max_heads <= 64) { > + rom->flags = cpu_to_le64(QXL_ROM_FLAG_MAX_HEADS); > + rom->max_heads = cpu_to_le16(d->max_heads); > + } rom does already carry information about the heads. How about simply applying the limit when filling rom->client_monitors_config in interface_client_monitors_config()? No device changes, no driver changes, alot less trouble. cheers, Gerd