qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Gabriel L. Somlo" <somlo@cmu.edu>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL v3 2/8] fw_cfg: add fw_cfg_modify_i16 (update) method
Date: Wed, 10 Jun 2015 08:35:25 +0200	[thread overview]
Message-ID: <1433918131-6850-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1433918131-6850-1-git-send-email-kraxel@redhat.com>

From: "Gabriel L. Somlo" <somlo@cmu.edu>

Allow the ability to modify the value of an existing 16-bit integer
fw_cfg item.

Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/nvram/fw_cfg.c         | 10 ++++++++++
 include/hw/nvram/fw_cfg.h |  1 +
 2 files changed, 11 insertions(+)

diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 68eff77..08b5cc3 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -484,6 +484,16 @@ void fw_cfg_add_i16(FWCfgState *s, uint16_t key, uint16_t value)
     fw_cfg_add_bytes(s, key, copy, sizeof(value));
 }
 
+void fw_cfg_modify_i16(FWCfgState *s, uint16_t key, uint16_t value)
+{
+    uint16_t *copy, *old;
+
+    copy = g_malloc(sizeof(value));
+    *copy = cpu_to_le16(value);
+    old = fw_cfg_modify_bytes_read(s, key, copy, sizeof(value));
+    g_free(old);
+}
+
 void fw_cfg_add_i32(FWCfgState *s, uint16_t key, uint32_t value)
 {
     uint32_t *copy;
diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h
index 6d8a8ac..bc6c4a0 100644
--- a/include/hw/nvram/fw_cfg.h
+++ b/include/hw/nvram/fw_cfg.h
@@ -67,6 +67,7 @@ typedef void (*FWCfgReadCallback)(void *opaque, uint32_t offset);
 void fw_cfg_add_bytes(FWCfgState *s, uint16_t key, void *data, size_t len);
 void fw_cfg_add_string(FWCfgState *s, uint16_t key, const char *value);
 void fw_cfg_add_i16(FWCfgState *s, uint16_t key, uint16_t value);
+void fw_cfg_modify_i16(FWCfgState *s, uint16_t key, uint16_t value);
 void fw_cfg_add_i32(FWCfgState *s, uint16_t key, uint32_t value);
 void fw_cfg_add_i64(FWCfgState *s, uint16_t key, uint64_t value);
 void fw_cfg_add_callback(FWCfgState *s, uint16_t key, FWCfgCallback callback,
-- 
1.8.3.1

  parent reply	other threads:[~2015-06-10  6:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  6:35 [Qemu-devel] [PULL v3 0/8] fw_cfg patch queue Gerd Hoffmann
2015-06-10  6:35 ` [Qemu-devel] [PULL v3 1/8] QemuOpts: increase number of vm_config_groups Gerd Hoffmann
2015-06-10  6:35 ` Gerd Hoffmann [this message]
2015-06-10  6:35 ` [Qemu-devel] [PULL v3 3/8] fw_cfg: fix FW_CFG_BOOT_DEVICE update on ppc and sparc Gerd Hoffmann
2015-06-10  6:35 ` [Qemu-devel] [PULL v3 4/8] fw_cfg: remove support for guest-side data writes Gerd Hoffmann
2015-06-10  6:35 ` [Qemu-devel] [PULL v3 5/8] fw_cfg: prevent selector key conflict Gerd Hoffmann
2015-06-10  6:35 ` [Qemu-devel] [PULL v3 6/8] fw_cfg: prohibit insertion of duplicate fw_cfg file names Gerd Hoffmann
2015-06-10  6:35 ` [Qemu-devel] [PULL v3 7/8] fw_cfg: insert fw_cfg file blobs via qemu cmdline Gerd Hoffmann
2015-06-10  6:35 ` [Qemu-devel] [PULL v3 8/8] bios-tables-test: handle false-positive smbios signature matches Gerd Hoffmann
2015-06-10 17:13 ` [Qemu-devel] [PULL v3 0/8] fw_cfg patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433918131-6850-3-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=somlo@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).