From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46419)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z2ZxT-0007jX-0O
	for qemu-devel@nongnu.org; Wed, 10 Jun 2015 02:57:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z2ZxO-0000nm-4E
	for qemu-devel@nongnu.org; Wed, 10 Jun 2015 02:57:54 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59771)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z2ZxN-0000ne-Vc
	for qemu-devel@nongnu.org; Wed, 10 Jun 2015 02:57:50 -0400
Message-ID: <1433919466.16508.12.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 10 Jun 2015 08:57:46 +0200
In-Reply-To: <CAFEAcA9XBxo2aoui9dwaPqcKU3Vuys0hF0VFomKM0NRSVR=9Hg@mail.gmail.com>
References: <1433846851-20552-1-git-send-email-kraxel@redhat.com>
	<CAFEAcA-+kw_syCPqPPr_=VWzvSPYrRKHQVfMQaLdo93pd0d0ow@mail.gmail.com>
	<5576F4A7.6090306@gmail.com>
	<CAFEAcA9XBxo2aoui9dwaPqcKU3Vuys0hF0VFomKM0NRSVR=9Hg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 00/12] audio patch queue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, =?UTF-8?Q?K=C5=91v=C3=A1g=C3=B3_Zolt=C3=A1n?= <dirty.ice.hu@gmail.com>

On Di, 2015-06-09 at 15:29 +0100, Peter Maydell wrote:
> On 9 June 2015 at 15:13, K=C5=91v=C3=A1g=C3=B3 Zolt=C3=A1n <dirty.ice.h=
u@gmail.com> wrote:
> > 2015-06-09 15:03 keltez=C3=A9ssel, Peter Maydell =C3=ADrta:
> >>
> >>
> >> ...and a further long list of errors which I assume are mostly
> >> run-on from not finding the header file.
> >>
> >> This looks like it's because configure is now using
> >> "dsound" by default rather than "winwave".
> >
> >
> > Yes, the winwave backend was removed, so dsound is the new default.
>=20
> Right, but you can't break compilation. At a minimum, we
> need a configure test so we don't try to build the dsound
> backend unless the compile environment supports it.

Yes.

> We might also want to consider retaining the winwave backend
> as a fallback.

I'd rather require a recent enough mingw compiler version for sound
support on windows.  DirectSound isn't exactly new, it was added with
Windows 95 (20 years ago!).  winwave is even older.

cheers,
  Gerd