From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2eM3-0008DS-4Y for qemu-devel@nongnu.org; Wed, 10 Jun 2015 07:39:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z2eLz-0000tK-BY for qemu-devel@nongnu.org; Wed, 10 Jun 2015 07:39:35 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:47863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z2eLz-0000rd-22 for qemu-devel@nongnu.org; Wed, 10 Jun 2015 07:39:31 -0400 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Jun 2015 12:39:28 +0100 From: Alexander Yarygin Date: Wed, 10 Jun 2015 14:38:14 +0300 Message-Id: <1433936297-7098-1-git-send-email-yarygin@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH RFC v2 0/3] Fix slow startup with many disks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Alexander Yarygin , Ekaterina Tumanova , Christian Borntraeger , Stefan Hajnoczi , Cornelia Huck , Paolo Bonzini Changes in v2: - Patch "block-backend: Introduce blk_drain() and replace blk_drain_all()" splitted to two. - blk_drain() moved to above virtio_blk_data_plane_stop(). During reset the aio_poll() function is called at least amount_of_disks^2 times: for_each disk virtio_blk_reset() bdrv_drain_all() for_each disk aio_poll() For example, startup with 1000 disks takes over 13 minutes. Patches 1 and 2 removes inner loop by using bdrv_drain() instead of bdrv_drain_all(). bdrv_drain() works on one disk at time. Since bdrv_drain_all() is still called in other places, patch 3 optimizes it for cases, where there are more disks than iothreads. Thanks. Alexander Yarygin (3): block-backend: Introduce blk_drain() virtio-blk: Use blk_drain() to drain IO requests block: Let bdrv_drain_all() to call aio_poll() for each AioContext block/block-backend.c | 5 +++++ block/io.c | 42 ++++++++++++++++++++++++++---------------- hw/block/virtio-blk.c | 11 ++++++----- include/sysemu/block-backend.h | 1 + 4 files changed, 38 insertions(+), 21 deletions(-) -- 1.9.1