From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59030)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z2zRx-0002e2-Sb
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 06:11:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z2zRs-00050I-UV
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 06:11:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Z2zRs-0004zS-Lr
	for qemu-devel@nongnu.org; Thu, 11 Jun 2015 06:11:00 -0400
Message-ID: <1434017457.27114.34.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 11 Jun 2015 12:10:57 +0200
In-Reply-To: <1434015506-6955-1-git-send-email-fziglio@redhat.com>
References: <1434015506-6955-1-git-send-email-fziglio@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] RFC: qxl: allow to specify head limit
	to qxl driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Frediano Ziglio <fziglio@redhat.com>
Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org

On Do, 2015-06-11 at 10:38 +0100, Frediano Ziglio wrote:
> libvirt has this as a video card parameter (actually set to 1 but not
> used). This parameter will allow to limit setting a use can do (which
> could be confusing).

Hmm.  So heads is '1' by default but ignored today.  When this starts to
be actually applied that will break existing multihead setups I suspect.

> This patch rely on some change in spice-protocol which are not still
> accepted. See
> http://lists.freedesktop.org/archives/spice-devel/2015-June/020221.html.

Spice-server changes, right?
Needs #ifdefs so qemu continues to build with old spice-server versions.
The spice-server changes need to be upstream first.

Also: when we pass on the limit to spice-server anyway spice-server can
take care to apply the limit both ways and not call the
->client_monitors_config() callback with more than $limit monitors.  Has
the advantage to reduce the test matrix:  Limit either works or doesn't.
There will be no spice-server/qemu version combination where the limit
is applied one way only.

  Gerd