From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z32Qj-0004Dw-Vf for qemu-devel@nongnu.org; Thu, 11 Jun 2015 09:22:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z32Qf-0007Nk-RD for qemu-devel@nongnu.org; Thu, 11 Jun 2015 09:22:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z32Qf-0007NV-MF for qemu-devel@nongnu.org; Thu, 11 Jun 2015 09:21:57 -0400 Message-ID: <1434028915.4927.169.camel@redhat.com> From: Alex Williamson Date: Thu, 11 Jun 2015 07:21:55 -0600 In-Reply-To: References: <1434012280-23556-1-git-send-email-eric.auger@linaro.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: replace g_malloc0_n by g_new0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Markus Armbruster , "Gonglei (Arei)" , eric.auger@st.com, QEMU Developers , Eric Auger On Thu, 2015-06-11 at 14:00 +0100, Peter Maydell wrote: > On 11 June 2015 at 09:44, Eric Auger wrote: > > g_malloc0_n() is introduced since glib-2.24 while QEMU currently > > requires glib-2.22. This may cause a link error on some distributions. > > > > Signed-off-by: Eric Auger > > > > --- > > > > v1 -> v2: > > - replace g_malloc0 by g_new0 > > --- > > hw/vfio/platform.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c > > index 35266a8..9382bb7 100644 > > --- a/hw/vfio/platform.c > > +++ b/hw/vfio/platform.c > > @@ -346,8 +346,7 @@ static int vfio_populate_device(VFIODevice *vbasedev) > > return ret; > > } > > > > - vdev->regions = g_malloc0_n(vbasedev->num_regions, > > - sizeof(VFIORegion *)); > > + vdev->regions = g_new0(VFIORegion *, vbasedev->num_regions); > > > > for (i = 0; i < vbasedev->num_regions; i++) { > > struct vfio_region_info reg_info = { .argsz = sizeof(reg_info) }; > > -- > > 1.8.3.2 > > This looks like the right fix to me -- if somebody would like to > give it a reviewed-by tag I can apply it to master as a buildfix... Thanks Peter Acked-by: Alex Williamson