From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Lu4-0005as-Si for qemu-devel@nongnu.org; Fri, 12 Jun 2015 06:09:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3Lu0-000678-U4 for qemu-devel@nongnu.org; Fri, 12 Jun 2015 06:09:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3Lu0-00066h-Q2 for qemu-devel@nongnu.org; Fri, 12 Jun 2015 06:09:32 -0400 From: Stefan Hajnoczi Date: Fri, 12 Jun 2015 11:09:16 +0100 Message-Id: <1434103761-29871-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1434103761-29871-1-git-send-email-stefanha@redhat.com> References: <1434103761-29871-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [RFC 4/9] block: keep bitmap if incremental backup job is cancelled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , famz@redhat.com, Jeff Cody , Max Reitz , vsementsov@parallels.com, Stefan Hajnoczi , John Snow Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret < 0. Signed-off-by: Stefan Hajnoczi --- block/backup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/backup.c b/block/backup.c index d3f648d..c1ad975 100644 --- a/block/backup.c +++ b/block/backup.c @@ -430,7 +430,7 @@ static void coroutine_fn backup_run(void *opaque) if (job->sync_bitmap) { BdrvDirtyBitmap *bm; - if (ret < 0) { + if (ret < 0 || block_job_is_cancelled(&job->common)) { /* Merge the successor back into the parent, delete nothing. */ bm = bdrv_reclaim_dirty_bitmap(bs, job->sync_bitmap, NULL); assert(bm); -- 2.4.2