qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 10/11] target-sh4: factorize fmov implementation
Date: Fri, 12 Jun 2015 12:40:37 +0200	[thread overview]
Message-ID: <1434105638-642-11-git-send-email-aurelien@aurel32.net> (raw)
In-Reply-To: <1434105638-642-1-git-send-email-aurelien@aurel32.net>

Reviewed-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 target-sh4/translate.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/target-sh4/translate.c b/target-sh4/translate.c
index 44d0e94..e8b9217 100644
--- a/target-sh4/translate.c
+++ b/target-sh4/translate.c
@@ -1010,24 +1010,19 @@ static void _decode_opc(DisasContext * ctx)
 	return;
     case 0xf00b: /* fmov {F,D,X}Rm,@-Rn - FPSCR: Nothing */
 	CHECK_FPU_ENABLED
+        TCGv addr = tcg_temp_new_i32();
+        tcg_gen_subi_i32(addr, REG(B11_8), 4);
         if (ctx->flags & FPSCR_SZ) {
-	    TCGv addr = tcg_temp_new_i32();
 	    int fr = XREG(B7_4);
-	    tcg_gen_subi_i32(addr, REG(B11_8), 4);
             tcg_gen_qemu_st_i32(cpu_fregs[fr+1], addr, ctx->memidx, MO_TEUL);
 	    tcg_gen_subi_i32(addr, addr, 4);
             tcg_gen_qemu_st_i32(cpu_fregs[fr], addr, ctx->memidx, MO_TEUL);
-	    tcg_gen_mov_i32(REG(B11_8), addr);
-	    tcg_temp_free(addr);
 	} else {
-	    TCGv addr;
-	    addr = tcg_temp_new_i32();
-	    tcg_gen_subi_i32(addr, REG(B11_8), 4);
             tcg_gen_qemu_st_i32(cpu_fregs[FREG(B7_4)], addr,
                                 ctx->memidx, MO_TEUL);
-	    tcg_gen_mov_i32(REG(B11_8), addr);
-	    tcg_temp_free(addr);
 	}
+        tcg_gen_mov_i32(REG(B11_8), addr);
+        tcg_temp_free(addr);
 	return;
     case 0xf006: /* fmov @(R0,Rm),{F,D,X}Rm - FPSCR: Nothing */
 	CHECK_FPU_ENABLED
-- 
2.1.4

  parent reply	other threads:[~2015-06-12 10:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12 10:40 [Qemu-devel] [PULL 00/11] sh4-next queue Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 01/11] linux-user: Default sh4 to sh7785 Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 02/11] linux-user: Add HWCAP for SH4 Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 03/11] sh4/r2d: convert to new MMIO accessor style Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 04/11] target-sh4: use bit number for SR constants Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 05/11] target-sh4: Split out T from SR Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 06/11] target-sh4: optimize addc using add2 Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 07/11] target-sh4: optimize subc using sub2 Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 08/11] target-sh4: optimize negc using add2 and sub2 Aurelien Jarno
2015-06-12 10:40 ` [Qemu-devel] [PULL 09/11] target-sh4: split out Q and M from of SR and optimize div1 Aurelien Jarno
2015-06-12 10:40 ` Aurelien Jarno [this message]
2015-06-12 10:40 ` [Qemu-devel] [PULL 11/11] target-sh4: remove dead code Aurelien Jarno
2015-06-12 14:38 ` [Qemu-devel] [PULL 00/11] sh4-next queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434105638-642-11-git-send-email-aurelien@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).