From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3OXA-0001jt-MW for qemu-devel@nongnu.org; Fri, 12 Jun 2015 08:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z3OX8-0007AZ-1O for qemu-devel@nongnu.org; Fri, 12 Jun 2015 08:58:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z3OX7-0007AT-SM for qemu-devel@nongnu.org; Fri, 12 Jun 2015 08:58:05 -0400 From: Stefan Hajnoczi Date: Fri, 12 Jun 2015 13:57:35 +0100 Message-Id: <1434113861-26495-11-git-send-email-stefanha@redhat.com> In-Reply-To: <1434113861-26495-1-git-send-email-stefanha@redhat.com> References: <1434113861-26495-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 10/16] xen_backend: Remove unused error handling of qemu_set_fd_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Fam Zheng , Stefan Hajnoczi From: Fam Zheng The function cannot fail, so the check is superfluous. Signed-off-by: Fam Zheng Message-id: 1433400324-7358-12-git-send-email-famz@redhat.com Signed-off-by: Stefan Hajnoczi --- hw/xen/xen_backend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c index b2cb22b..2510e2e 100644 --- a/hw/xen/xen_backend.c +++ b/hw/xen/xen_backend.c @@ -714,9 +714,7 @@ int xen_be_init(void) return -1; } - if (qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL) < 0) { - goto err; - } + qemu_set_fd_handler(xs_fileno(xenstore), xenstore_update, NULL, NULL); if (xen_xc == XC_HANDLER_INITIAL_VALUE) { /* Check if xen_init() have been called */ -- 2.4.2