qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 14/16] qapi-types: Drop unused members parameters
Date: Fri, 12 Jun 2015 16:51:12 +0200	[thread overview]
Message-ID: <1434120674-8122-15-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1434120674-8122-1-git-send-email-armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/qapi-types.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 86e5ddc..c408542 100644
--- a/scripts/qapi-types.py
+++ b/scripts/qapi-types.py
@@ -12,7 +12,7 @@
 from ordereddict import OrderedDict
 from qapi import *
 
-def generate_fwd_struct(name, members, builtin_type=False):
+def generate_fwd_struct(name, builtin_type=False):
     if builtin_type:
         return mcgen('''
 
@@ -43,7 +43,7 @@ typedef struct %(name)sList
 ''',
                  name=c_name(name))
 
-def generate_fwd_enum_struct(name, members):
+def generate_fwd_enum_struct(name):
     return mcgen('''
 typedef struct %(name)sList
 {
@@ -332,26 +332,26 @@ exprs = parse_schema(input_file)
 
 fdecl.write(guardstart("QAPI_TYPES_BUILTIN_STRUCT_DECL"))
 for typename in builtin_types.keys():
-    fdecl.write(generate_fwd_struct(typename, None, builtin_type=True))
+    fdecl.write(generate_fwd_struct(typename, builtin_type=True))
 fdecl.write(guardend("QAPI_TYPES_BUILTIN_STRUCT_DECL"))
 
 for expr in exprs:
     ret = "\n"
     if expr.has_key('struct'):
-        ret += generate_fwd_struct(expr['struct'], expr['data'])
+        ret += generate_fwd_struct(expr['struct'])
     elif expr.has_key('enum'):
         ret += generate_enum(expr['enum'], expr['data']) + "\n"
-        ret += generate_fwd_enum_struct(expr['enum'], expr['data'])
+        ret += generate_fwd_enum_struct(expr['enum'])
         fdef.write(generate_enum_lookup(expr['enum'], expr['data']))
     elif expr.has_key('union'):
-        ret += generate_fwd_struct(expr['union'], expr['data']) + "\n"
+        ret += generate_fwd_struct(expr['union']) + "\n"
         enum_define = discriminator_find_enum_define(expr)
         if not enum_define:
             ret += generate_enum('%sKind' % expr['union'], expr['data'].keys())
             fdef.write(generate_enum_lookup('%sKind' % expr['union'],
                                             expr['data'].keys()))
     elif expr.has_key('alternate'):
-        ret += generate_fwd_struct(expr['alternate'], expr['data']) + "\n"
+        ret += generate_fwd_struct(expr['alternate']) + "\n"
         ret += generate_enum('%sKind' % expr['alternate'], expr['data'].keys())
         fdef.write(generate_enum_lookup('%sKind' % expr['alternate'],
                                         expr['data'].keys()))
-- 
1.9.3

  parent reply	other threads:[~2015-06-12 14:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12 14:50 [Qemu-devel] [PATCH 00/16] qapi: Miscellaneous fixes and cleanups Markus Armbruster
2015-06-12 14:50 ` [Qemu-devel] [PATCH 01/16] MAINTAINERS: Fix up QAPI and QAPI schema file patterns Markus Armbruster
2015-06-12 22:50   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 02/16] qapi: Drop bogus command from docs Markus Armbruster
2015-06-12 22:51   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 03/16] qapi: Eliminate superfluous QAPISchema attribute input_dir Markus Armbruster
2015-06-12 22:54   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 04/16] qapi: Eliminate superfluous QAPISchema attribute include_hist Markus Armbruster
2015-06-12 23:11   ` Eric Blake
2015-06-16  8:43     ` Markus Armbruster
2015-06-12 14:51 ` [Qemu-devel] [PATCH 05/16] qapi: Improve a couple of confusing variable names Markus Armbruster
2015-06-12 23:16   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 06/16] qapi: Fix file name in error messages for included files Markus Armbruster
2015-06-12 23:19   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 07/16] qapi: Simplify inclusion cycle detection Markus Armbruster
2015-06-12 23:30   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 08/16] qapi: Fix to reject stray 't', 'f' and 'n' Markus Armbruster
2015-06-12 23:35   ` Eric Blake
2015-06-16  8:31     ` Markus Armbruster
2015-06-12 14:51 ` [Qemu-devel] [PATCH 09/16] qapi: Move exprs checking from parse_schema() to check_exprs() Markus Armbruster
2015-06-12 23:41   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 10/16] qapi: Better separate the different kinds of helpers Markus Armbruster
2015-06-12 23:42   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 11/16] tests/qapi-schema: New flat union array branch test case Markus Armbruster
2015-06-13 16:55   ` Eric Blake
2015-06-16  8:33     ` Markus Armbruster
2015-06-12 14:51 ` [Qemu-devel] [PATCH 12/16] qapi: Catch and reject flat union branch of array type Markus Armbruster
2015-06-14  2:19   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 13/16] qapi-types: Don't filter out expressions with 'gen' Markus Armbruster
2015-06-14  2:20   ` Eric Blake
2015-06-12 14:51 ` Markus Armbruster [this message]
2015-06-14  2:21   ` [Qemu-devel] [PATCH 14/16] qapi-types: Drop unused members parameters Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 15/16] qapi-types: Split generate_fwd_builtin() off generate_fwd_struct() Markus Armbruster
2015-06-14  2:22   ` Eric Blake
2015-06-12 14:51 ` [Qemu-devel] [PATCH 16/16] qapi-types: Bury code dead since commit 6b5abc7 Markus Armbruster
2015-06-14  2:23   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434120674-8122-15-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).