From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Kővágó, Zoltán" <DirtY.iCE.hu@gmail.com>
Subject: [Qemu-devel] [PULL 16/20] audio: remove plive
Date: Mon, 15 Jun 2015 14:28:07 +0200 [thread overview]
Message-ID: <1434371291-6994-17-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1434371291-6994-1-git-send-email-kraxel@redhat.com>
From: Kővágó, Zoltán <dirty.ice.hu@gmail.com>
It was useless even 3 years ago, so it can probably safely go away:
https://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg02427.html
Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
audio/audio.c | 12 ------------
audio/audio_template.h | 41 -----------------------------------------
2 files changed, 53 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index cb1cba9..5be4b15 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -30,7 +30,6 @@
#define AUDIO_CAP "audio"
#include "audio_int.h"
-/* #define DEBUG_PLIVE */
/* #define DEBUG_LIVE */
/* #define DEBUG_OUT */
/* #define DEBUG_CAPTURE */
@@ -66,7 +65,6 @@ static struct {
int hertz;
int64_t ticks;
} period;
- int plive;
int try_poll_in;
int try_poll_out;
} conf = {
@@ -95,7 +93,6 @@ static struct {
},
.period = { .hertz = 100 },
- .plive = 0,
.try_poll_in = 1,
.try_poll_out = 1,
};
@@ -1443,9 +1440,6 @@ static void audio_run_out (AudioState *s)
while (sw) {
sw1 = sw->entries.le_next;
if (!sw->active && !sw->callback.fn) {
-#ifdef DEBUG_PLIVE
- dolog ("Finishing with old voice\n");
-#endif
audio_close_out (sw);
}
sw = sw1;
@@ -1637,12 +1631,6 @@ static struct audio_option audio_options[] = {
.valp = &conf.period.hertz,
.descr = "Timer period in HZ (0 - use lowest possible)"
},
- {
- .name = "PLIVE",
- .tag = AUD_OPT_BOOL,
- .valp = &conf.plive,
- .descr = "(undocumented)"
- },
{ /* End of list */ }
};
diff --git a/audio/audio_template.h b/audio/audio_template.h
index f716d97..99b27b2 100644
--- a/audio/audio_template.h
+++ b/audio/audio_template.h
@@ -398,10 +398,6 @@ SW *glue (AUD_open_, TYPE) (
)
{
AudioState *s = &glob_audio_state;
-#ifdef DAC
- int live = 0;
- SW *old_sw = NULL;
-#endif
if (audio_bug (AUDIO_FUNC, !card || !name || !callback_fn || !as)) {
dolog ("card=%p name=%p callback_fn=%p as=%p\n",
@@ -426,29 +422,6 @@ SW *glue (AUD_open_, TYPE) (
return sw;
}
-#ifdef DAC
- if (conf.plive && sw && (!sw->active && !sw->empty)) {
- live = sw->total_hw_samples_mixed;
-
-#ifdef DEBUG_PLIVE
- dolog ("Replacing voice %s with %d live samples\n", SW_NAME (sw), live);
- dolog ("Old %s freq %d, bits %d, channels %d\n",
- SW_NAME (sw), sw->info.freq, sw->info.bits, sw->info.nchannels);
- dolog ("New %s freq %d, bits %d, channels %d\n",
- name,
- as->freq,
- (as->fmt == AUD_FMT_S16 || as->fmt == AUD_FMT_U16) ? 16 : 8,
- as->nchannels);
-#endif
-
- if (live) {
- old_sw = sw;
- old_sw->callback.fn = NULL;
- sw = NULL;
- }
- }
-#endif
-
if (!glue (conf.fixed_, TYPE).enabled && sw) {
glue (AUD_close_, TYPE) (card, sw);
sw = NULL;
@@ -481,20 +454,6 @@ SW *glue (AUD_open_, TYPE) (
sw->callback.fn = callback_fn;
sw->callback.opaque = callback_opaque;
-#ifdef DAC
- if (live) {
- int mixed =
- (live << old_sw->info.shift)
- * old_sw->info.bytes_per_second
- / sw->info.bytes_per_second;
-
-#ifdef DEBUG_PLIVE
- dolog ("Silence will be mixed %d\n", mixed);
-#endif
- sw->total_hw_samples_mixed += mixed;
- }
-#endif
-
#ifdef DEBUG_AUDIO
dolog ("%s\n", name);
audio_pcm_print_info ("hw", &sw->hw->info);
--
1.8.3.1
next prev parent reply other threads:[~2015-06-15 12:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:27 [Qemu-devel] [PULL 00/20] audio patch queue Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 01/20] audio: remove esd backend Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 02/20] audio: remove fmod backend Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 03/20] audio: remove winwave audio driver Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 04/20] only enable dsound in case the header file is present Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 05/20] audio: expose drv_opaque to init_out and init_in Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 06/20] paaudio: do not use global variables Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 07/20] alsaaudio: " Gerd Hoffmann
2015-06-15 12:27 ` [Qemu-devel] [PULL 08/20] ossaudio: " Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 09/20] wavaudio: " Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 10/20] paaudio: fix possible resource leak Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 11/20] dsoundaudio: do not use global variables Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 12/20] coreaudio: do not use global variables where possible Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 13/20] sdlaudio: do not allow multiple instances Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 14/20] MAINTAINERS: remove malc from audio Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 15/20] audio: remove LOG_TO_MONITOR along with default_mon Gerd Hoffmann
2015-06-15 12:28 ` Gerd Hoffmann [this message]
2015-06-15 12:28 ` [Qemu-devel] [PULL 17/20] dsoundaudio: remove *_retries kludges Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 18/20] dsoundaudio: remove primary buffer Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 19/20] alsaaudio: use trace events instead of verbose Gerd Hoffmann
2015-06-15 12:28 ` [Qemu-devel] [PULL 20/20] ossaudio: use trace events instead of debug config flag Gerd Hoffmann
2015-06-15 17:03 ` [Qemu-devel] [PULL 00/20] audio patch queue Peter Maydell
2015-06-15 17:05 ` Peter Maydell
2015-06-16 7:50 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434371291-6994-17-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=DirtY.iCE.hu@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).