qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Aurelien Jarno <aurelien@aurel32.net>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 03/10] virtio-ccw: disable ioevent bit when ioeventfds are not enabled
Date: Mon, 15 Jun 2015 17:57:02 +0200	[thread overview]
Message-ID: <1434383829-26451-4-git-send-email-aurelien@aurel32.net> (raw)
In-Reply-To: <1434383829-26451-1-git-send-email-aurelien@aurel32.net>

This remove the corresponding error messages in TCG mode, and allow to
simplify the s390_assign_subch_ioeventfd() function.

CC: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 hw/s390x/virtio-ccw.c | 4 ++++
 target-s390x/cpu.h    | 6 +-----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index b7a88d6..e32ada9 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -1401,6 +1401,10 @@ static void virtio_ccw_device_plugged(DeviceState *d, Error **errp)
         return;
     }
 
+    if (!kvm_eventfds_enabled()) {
+        dev->flags &= ~VIRTIO_CCW_FLAG_USE_IOEVENTFD;
+    }
+
     sch->id.cu_model = virtio_bus_get_vdev_id(&dev->bus);
 
     css_generate_sch_crws(sch->cssid, sch->ssid, sch->schid,
diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index 584e74b..08a79dd 100644
--- a/target-s390x/cpu.h
+++ b/target-s390x/cpu.h
@@ -1214,11 +1214,7 @@ static inline int s390_assign_subch_ioeventfd(EventNotifier *notifier,
                                               uint32_t sch_id, int vq,
                                               bool assign)
 {
-    if (kvm_enabled()) {
-        return kvm_s390_assign_subch_ioeventfd(notifier, sch_id, vq, assign);
-    } else {
-        return -ENOSYS;
-    }
+    return kvm_s390_assign_subch_ioeventfd(notifier, sch_id, vq, assign);
 }
 
 #ifdef CONFIG_KVM
-- 
2.1.4

  parent reply	other threads:[~2015-06-15 15:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-15 15:56 [Qemu-devel] [PATCH 00/10] target-s390x: add support for CCW in TCG mode Aurelien Jarno
2015-06-15 15:57 ` [Qemu-devel] [PATCH 01/10] s390/ioinst: fix IO_INT_WORD_ISC macro Aurelien Jarno
2015-06-15 18:40   ` Christian Borntraeger
2015-06-15 15:57 ` [Qemu-devel] [PATCH 02/10] s390/ioinst: fix endianness in ioinst_schib_valid Aurelien Jarno
2015-06-15 15:57 ` Aurelien Jarno [this message]
2015-06-15 15:57 ` [Qemu-devel] [PATCH 04/10] target-s390x: fix setcc in TCG mode Aurelien Jarno
2015-06-15 15:57 ` [Qemu-devel] [PATCH 05/10] target-s390x: correctly initialize ext interrupt queue Aurelien Jarno
2015-06-15 15:57 ` [Qemu-devel] [PATCH 06/10] target-s390x: initialize I/O " Aurelien Jarno
2015-06-15 15:57 ` [Qemu-devel] [PATCH 07/10] target-s390x: fix s390_cpu_initial_reset Aurelien Jarno
2015-06-15 15:57 ` [Qemu-devel] [PATCH 08/10] target-s390x: wire up DIAG IPL in TCG mode Aurelien Jarno
2015-06-15 15:57 ` [Qemu-devel] [PATCH 09/10] target-s390x: wire up DIAG REIPL " Aurelien Jarno
2015-06-15 15:57 ` [Qemu-devel] [PATCH 10/10] target-s390x: wire up I/O instructions " Aurelien Jarno
2015-06-16 16:19 ` [Qemu-devel] [PATCH 00/10] target-s390x: add support for CCW " Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434383829-26451-4-git-send-email-aurelien@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).