qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mdroth@linux.vnet.ibm.com, stefanha@redhat.com,
	lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v2 06/11] tpm: Avoid qerror_report() outside QMP command handlers
Date: Tue, 16 Jun 2015 16:21:42 +0200	[thread overview]
Message-ID: <1434464507-13001-7-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1434464507-13001-1-git-send-email-armbru@redhat.com>

qerror_report() is a transitional interface to help with converting
existing monitor commands to QMP.  It should not be used elsewhere.
Replace by error_report().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 tpm.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tpm.c b/tpm.c
index 8dadc67..c8889fa 100644
--- a/tpm.c
+++ b/tpm.c
@@ -140,22 +140,21 @@ static int configure_tpm(QemuOpts *opts)
 
     id = qemu_opts_id(opts);
     if (id == NULL) {
-        qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETER, "id");
+        error_report(QERR_MISSING_PARAMETER, "id");
         return 1;
     }
 
     value = qemu_opt_get(opts, "type");
     if (!value) {
-        qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_MISSING_PARAMETER,
-                      "type");
+        error_report(QERR_MISSING_PARAMETER, "type");
         tpm_display_backend_drivers();
         return 1;
     }
 
     be = tpm_get_backend_driver(value);
     if (be == NULL) {
-        qerror_report(ERROR_CLASS_GENERIC_ERROR, QERR_INVALID_PARAMETER_VALUE,
-                      "type", "a TPM backend type");
+        error_report(QERR_INVALID_PARAMETER_VALUE,
+                     "type", "a TPM backend type");
         tpm_display_backend_drivers();
         return 1;
     }
-- 
1.9.3

  parent reply	other threads:[~2015-06-16 14:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16 14:21 [Qemu-devel] [PATCH v2 00/11] Sprint to the finish: purge QError Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 01/11] QemuOpts: Wean off qerror_report_err() Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 02/11] vl: Avoid qerror_report() outside QMP command handlers Markus Armbruster
2015-06-17 10:54   ` Stefan Hajnoczi
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 03/11] vl: Use error_report() for --display errors Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 04/11] qerror: Eliminate QERR_DEVICE_NOT_FOUND Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 05/11] qerror: Clean up QERR_ macros to expand into a single string Markus Armbruster
2015-06-16 14:21 ` Markus Armbruster [this message]
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 07/11] qmp: Wean off qerror_report() Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 08/11] qerror: Finally unused, clean up Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 09/11] qerror: Move #include out of qerror.h Markus Armbruster
2015-06-19 18:07   ` Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 10/11] Include qapi/qmp/qerror.h exactly where needed Markus Armbruster
2015-06-16 14:21 ` [Qemu-devel] [PATCH v2 11/11] Include monitor/monitor.h " Markus Armbruster
2015-06-19 18:25   ` Markus Armbruster
2015-06-17 10:55 ` [Qemu-devel] [PATCH v2 00/11] Sprint to the finish: purge QError Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434464507-13001-7-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).