From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sp2-0000qH-1V for qemu-devel@nongnu.org; Tue, 16 Jun 2015 11:30:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4sox-0007Dl-29 for qemu-devel@nongnu.org; Tue, 16 Jun 2015 11:30:43 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:42420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4sow-0007Cf-EY for qemu-devel@nongnu.org; Tue, 16 Jun 2015 11:30:39 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Jun 2015 01:30:34 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 65BB53578052 for ; Wed, 17 Jun 2015 01:30:32 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5GFUOc462062834 for ; Wed, 17 Jun 2015 01:30:32 +1000 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5GFTxar032095 for ; Wed, 17 Jun 2015 01:29:59 +1000 From: "Aneesh Kumar K.V" Date: Tue, 16 Jun 2015 20:59:35 +0530 Message-Id: <1434468576-18581-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1434468576-18581-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1434468576-18581-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 1/2] virtfs-proxy-helper: add missing long option terminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws, peter.maydell@linaro.org Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , "Aneesh Kumar K.V" From: Stefan Hajnoczi The getopt_long(3) long options array must have a zeroed terminator. This patch solves a segmentation fault when an unknown command-line option is encountered: $ fsdev/virtfs-proxy-helper --help Segmentation fault (core dumped) Signed-off-by: Stefan Hajnoczi Signed-off-by: Aneesh Kumar K.V --- fsdev/virtfs-proxy-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c index a698e2dbb37b..91e8b9b7f1cf 100644 --- a/fsdev/virtfs-proxy-helper.c +++ b/fsdev/virtfs-proxy-helper.c @@ -49,6 +49,7 @@ static struct option helper_opts[] = { {"socket", required_argument, NULL, 's'}, {"uid", required_argument, NULL, 'u'}, {"gid", required_argument, NULL, 'g'}, + {}, }; static bool is_daemon; -- 2.1.4