qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Yarygin <yarygin@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org,
	Alexander Yarygin <yarygin@linux.vnet.ibm.com>,
	Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH v3 0/2] Fix slow startup with many disks
Date: Wed, 17 Jun 2015 13:37:18 +0300	[thread overview]
Message-ID: <1434537440-28236-1-git-send-email-yarygin@linux.vnet.ibm.com> (raw)

Changes in v3:
   - Added aio_context_acquire/aio_context_release around blk_drain() in
     "virtio-blk: Use blk_drain() to drain IO requests" + updated commit
     description

Please update Cc: qemu-stable@ if it necessarily.

Changes in v2:
    - Patch "block-backend: Introduce blk_drain() and replace blk_drain_all()"
      splitted to two.
    - blk_drain() moved to above virtio_blk_data_plane_stop().

Previous thread:
http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg02786.html

During reset the aio_poll() function is called at least amount_of_disks^2 times:

for_each disk
    virtio_blk_reset()
        bdrv_drain_all()
                for_each disk
                         aio_poll()

For example, startup with 1000 disks takes over 13 minutes.

Patches 1 and 2 removes inner loop by using bdrv_drain() instead
of bdrv_drain_all(). bdrv_drain() works on one disk at time.

Since bdrv_drain_all() is still called in other places, patch 3 optimizes
it for cases, where there are more disks than iothreads.

Thanks.

Alexander Yarygin (2):
  block-backend: Introduce blk_drain()
  virtio-blk: Use blk_drain() to drain IO requests

 block/block-backend.c          |  5 +++++
 hw/block/virtio-blk.c          | 15 ++++++++++-----
 include/sysemu/block-backend.h |  1 +
 3 files changed, 16 insertions(+), 5 deletions(-)

-- 
1.9.1

             reply	other threads:[~2015-06-17 10:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-17 10:37 Alexander Yarygin [this message]
2015-06-17 10:37 ` [Qemu-devel] [PATCH v3 1/2] block-backend: Introduce blk_drain() Alexander Yarygin
2015-06-17 10:37 ` [Qemu-devel] [PATCH v3 2/2] virtio-blk: Use blk_drain() to drain IO requests Alexander Yarygin
2015-06-26  9:26   ` Markus Armbruster
2015-06-26 14:00     ` Alexander Yarygin
2015-06-29  6:10       ` Markus Armbruster
2015-06-30 13:52         ` Stefan Hajnoczi
2015-07-01 15:52           ` Markus Armbruster
2015-07-02  8:21             ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-06-18 15:53 ` [Qemu-devel] [PATCH v3 0/2] Fix slow startup with many disks Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434537440-28236-1-git-send-email-yarygin@linux.vnet.ibm.com \
    --to=yarygin@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=tumanova@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).