From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 18/26] target-s390x: basic PER event handling
Date: Wed, 17 Jun 2015 12:43:01 +0200 [thread overview]
Message-ID: <1434537789-63782-19-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1434537789-63782-1-git-send-email-agraf@suse.de>
From: Aurelien Jarno <aurelien@aurel32.net>
This patch add basic support to generate PER exceptions. It adds two
fields to the cpu structure to record for the PER address and PER
code & ATMID values. When an exception is triggered and a PER event is
pending, the two PER values are copied to the lowcore area.
At the end of an instruction, an helper is checking for a possible
pending PER event and triggers an exception in that case. For that to
work with branches, we need to disable TB chaining when PER is
activated. Fortunately it's already in the TB flags.
Finally in case of a SERVICE CALL exception, we need to trigger the PER
exception immediately after.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
target-s390x/cpu.h | 3 +++
target-s390x/helper.c | 54 ++++++++++++++++++++++++++++++----------------
target-s390x/helper.h | 1 +
target-s390x/misc_helper.c | 15 +++++++++++++
target-s390x/translate.c | 18 +++++++++++++++-
5 files changed, 71 insertions(+), 20 deletions(-)
diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index d3137be..f830208 100644
--- a/target-s390x/cpu.h
+++ b/target-s390x/cpu.h
@@ -111,6 +111,9 @@ typedef struct CPUS390XState {
uint32_t int_svc_code;
uint32_t int_svc_ilen;
+ uint64_t per_address;
+ uint16_t per_perc_atmid;
+
uint64_t cregs[16]; /* control registers */
ExtQueue ext_queue[MAX_EXT_QUEUE];
diff --git a/target-s390x/helper.c b/target-s390x/helper.c
index 90d273c..ec847a2 100644
--- a/target-s390x/helper.c
+++ b/target-s390x/helper.c
@@ -250,25 +250,6 @@ void do_restart_interrupt(CPUS390XState *env)
load_psw(env, mask, addr);
}
-static void do_svc_interrupt(CPUS390XState *env)
-{
- uint64_t mask, addr;
- LowCore *lowcore;
-
- lowcore = cpu_map_lowcore(env);
-
- lowcore->svc_code = cpu_to_be16(env->int_svc_code);
- lowcore->svc_ilen = cpu_to_be16(env->int_svc_ilen);
- lowcore->svc_old_psw.mask = cpu_to_be64(get_psw_mask(env));
- lowcore->svc_old_psw.addr = cpu_to_be64(env->psw.addr + env->int_svc_ilen);
- mask = be64_to_cpu(lowcore->svc_new_psw.mask);
- addr = be64_to_cpu(lowcore->svc_new_psw.addr);
-
- cpu_unmap_lowcore(lowcore);
-
- load_psw(env, mask, addr);
-}
-
static void do_program_interrupt(CPUS390XState *env)
{
uint64_t mask, addr;
@@ -292,6 +273,14 @@ static void do_program_interrupt(CPUS390XState *env)
lowcore = cpu_map_lowcore(env);
+ /* Signal PER events with the exception. */
+ if (env->per_perc_atmid) {
+ env->int_pgm_code |= PGM_PER;
+ lowcore->per_address = cpu_to_be64(env->per_address);
+ lowcore->per_perc_atmid = cpu_to_be16(env->per_perc_atmid);
+ env->per_perc_atmid = 0;
+ }
+
lowcore->pgm_ilen = cpu_to_be16(ilen);
lowcore->pgm_code = cpu_to_be16(env->int_pgm_code);
lowcore->program_old_psw.mask = cpu_to_be64(get_psw_mask(env));
@@ -308,6 +297,33 @@ static void do_program_interrupt(CPUS390XState *env)
load_psw(env, mask, addr);
}
+static void do_svc_interrupt(CPUS390XState *env)
+{
+ uint64_t mask, addr;
+ LowCore *lowcore;
+
+ lowcore = cpu_map_lowcore(env);
+
+ lowcore->svc_code = cpu_to_be16(env->int_svc_code);
+ lowcore->svc_ilen = cpu_to_be16(env->int_svc_ilen);
+ lowcore->svc_old_psw.mask = cpu_to_be64(get_psw_mask(env));
+ lowcore->svc_old_psw.addr = cpu_to_be64(env->psw.addr + env->int_svc_ilen);
+ mask = be64_to_cpu(lowcore->svc_new_psw.mask);
+ addr = be64_to_cpu(lowcore->svc_new_psw.addr);
+
+ cpu_unmap_lowcore(lowcore);
+
+ load_psw(env, mask, addr);
+
+ /* When a PER event is pending, the PER exception has to happen
+ immediately after the SERVICE CALL one. */
+ if (env->per_perc_atmid) {
+ env->int_pgm_code = PGM_PER;
+ env->int_pgm_ilen = env->int_svc_ilen;
+ do_program_interrupt(env);
+ }
+}
+
#define VIRTIO_SUBCODE_64 0x0D00
static void do_ext_interrupt(CPUS390XState *env)
diff --git a/target-s390x/helper.h b/target-s390x/helper.h
index 53db519..7d2fa90 100644
--- a/target-s390x/helper.h
+++ b/target-s390x/helper.h
@@ -116,6 +116,7 @@ DEF_HELPER_FLAGS_2(lura, TCG_CALL_NO_WG, i64, env, i64)
DEF_HELPER_FLAGS_2(lurag, TCG_CALL_NO_WG, i64, env, i64)
DEF_HELPER_FLAGS_3(stura, TCG_CALL_NO_WG, void, env, i64, i64)
DEF_HELPER_FLAGS_3(sturg, TCG_CALL_NO_WG, void, env, i64, i64)
+DEF_HELPER_1(per_check_exception, void, env)
DEF_HELPER_2(xsch, void, env, i64)
DEF_HELPER_2(csch, void, env, i64)
diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c
index 7d66ce1..e636464 100644
--- a/target-s390x/misc_helper.c
+++ b/target-s390x/misc_helper.c
@@ -594,3 +594,18 @@ void HELPER(chsc)(CPUS390XState *env, uint64_t inst)
ioinst_handle_chsc(cpu, inst >> 16);
}
#endif
+
+#ifndef CONFIG_USER_ONLY
+void HELPER(per_check_exception)(CPUS390XState *env)
+{
+ CPUState *cs = CPU(s390_env_get_cpu(env));
+
+ if (env->per_perc_atmid) {
+ env->int_pgm_code = PGM_PER;
+ env->int_pgm_ilen = get_ilen(cpu_ldub_code(env, env->per_address));
+
+ cs->exception_index = EXCP_PGM;
+ cpu_loop_exit(cs);
+ }
+}
+#endif
diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index df3389d..2013a81 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -568,7 +568,8 @@ static int use_goto_tb(DisasContext *s, uint64_t dest)
return (((dest & TARGET_PAGE_MASK) == (s->tb->pc & TARGET_PAGE_MASK)
|| (dest & TARGET_PAGE_MASK) == ((s->pc - 1) & TARGET_PAGE_MASK))
&& !s->singlestep_enabled
- && !(s->tb->cflags & CF_LAST_IO));
+ && !(s->tb->cflags & CF_LAST_IO)
+ && !(s->tb->flags & FLAG_MASK_PER));
}
static void account_noninline_branch(DisasContext *s, int cc_op)
@@ -5234,6 +5235,21 @@ static ExitStatus translate_one(CPUS390XState *env, DisasContext *s)
tcg_temp_free_i64(o.addr1);
}
+#ifndef CONFIG_USER_ONLY
+ if (s->tb->flags & FLAG_MASK_PER) {
+ /* An exception might be triggered, save PSW if not already done. */
+ if (ret == NO_EXIT || ret == EXIT_PC_STALE) {
+ tcg_gen_movi_i64(psw_addr, s->next_pc);
+ }
+
+ /* Save off cc. */
+ update_cc_op(s);
+
+ /* Call the helper to check for a possible PER exception. */
+ gen_helper_per_check_exception(cpu_env);
+ }
+#endif
+
/* Advance to the next instruction. */
s->pc = s->next_pc;
return ret;
--
1.7.12.4
next prev parent reply other threads:[~2015-06-17 10:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 10:42 [Qemu-devel] [PULL 00/26] s390 patch queue 2015-06-17 Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 01/26] s390/ioinst: fix IO_INT_WORD_ISC macro Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 02/26] s390/ioinst: fix endianness in ioinst_schib_valid Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 03/26] virtio-ccw: disable ioevent bit when ioeventfds are not enabled Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 04/26] target-s390x: fix setcc in TCG mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 05/26] target-s390x: correctly initialize ext interrupt queue Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 06/26] target-s390x: initialize I/O " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 07/26] target-s390x: fix s390_cpu_initial_reset Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 08/26] target-s390x: wire up DIAG IPL in TCG mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 09/26] target-s390x: wire up DIAG REIPL " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 10/26] target-s390x: wire up I/O instructions " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 11/26] softmmu: provide tlb_vaddr_to_host function for user mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 12/26] target-s390x: function to adjust the length wrt page boundary Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 13/26] target-s390x: mvc_fast_memset: access memory through softmmu Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 14/26] target-s390x: mvc_fast_memmove: " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 15/26] target-s390x: add PER related constants Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 16/26] target-s390x: add get_per_atmid function Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 17/26] target-s390x: add get_per_in_range function Alexander Graf
2015-06-17 10:43 ` Alexander Graf [this message]
2015-06-17 10:43 ` [Qemu-devel] [PULL 19/26] target-s390x: PER successful-branching event support Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 20/26] target-s390x: PER instruction-fetch " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 21/26] translate-all: fix watchpoints if retranslation not possible Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 22/26] target-s390x: PER storage-alteration event support Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 23/26] target-s390x: PER store-using-real-address " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 24/26] target-s390x: PER instruction-fetch nullification " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 25/26] target-s390x: PER: add Breaking-Event-Address register Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 26/26] s390x: Switch to s390-ccw machine as default Alexander Graf
2015-06-17 12:11 ` [Qemu-devel] [PULL 00/26] s390 patch queue 2015-06-17 Christian Borntraeger
2015-06-17 13:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434537789-63782-19-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).