From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 19/26] target-s390x: PER successful-branching event support
Date: Wed, 17 Jun 2015 12:43:02 +0200 [thread overview]
Message-ID: <1434537789-63782-20-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1434537789-63782-1-git-send-email-agraf@suse.de>
From: Aurelien Jarno <aurelien@aurel32.net>
For the PER successful-branching event support, we can't rely on any
QEMU infrastucture. We therefore call an helper in all places where
a branch can be taken. We have to pay attention to the branch to next
case, as it's still a taken branch.
We don't need to care about the cases using goto_tb, as we have disabled
them in the previous patch.
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
target-s390x/helper.h | 1 +
target-s390x/misc_helper.c | 11 +++++++++++
target-s390x/translate.c | 39 +++++++++++++++++++++++++++++++++++++++
3 files changed, 51 insertions(+)
diff --git a/target-s390x/helper.h b/target-s390x/helper.h
index 7d2fa90..89197cb 100644
--- a/target-s390x/helper.h
+++ b/target-s390x/helper.h
@@ -117,6 +117,7 @@ DEF_HELPER_FLAGS_2(lurag, TCG_CALL_NO_WG, i64, env, i64)
DEF_HELPER_FLAGS_3(stura, TCG_CALL_NO_WG, void, env, i64, i64)
DEF_HELPER_FLAGS_3(sturg, TCG_CALL_NO_WG, void, env, i64, i64)
DEF_HELPER_1(per_check_exception, void, env)
+DEF_HELPER_FLAGS_3(per_branch, TCG_CALL_NO_RWG, void, env, i64, i64)
DEF_HELPER_2(xsch, void, env, i64)
DEF_HELPER_2(csch, void, env, i64)
diff --git a/target-s390x/misc_helper.c b/target-s390x/misc_helper.c
index e636464..bc28f9d 100644
--- a/target-s390x/misc_helper.c
+++ b/target-s390x/misc_helper.c
@@ -608,4 +608,15 @@ void HELPER(per_check_exception)(CPUS390XState *env)
cpu_loop_exit(cs);
}
}
+
+void HELPER(per_branch)(CPUS390XState *env, uint64_t from, uint64_t to)
+{
+ if ((env->cregs[9] & PER_CR9_EVENT_BRANCH)) {
+ if (!(env->cregs[9] & PER_CR9_CONTROL_BRANCH_ADDRESS)
+ || get_per_in_range(env, to)) {
+ env->per_address = from;
+ env->per_perc_atmid = PER_CODE_EVENT_BRANCH | get_per_atmid(env);
+ }
+ }
+}
#endif
diff --git a/target-s390x/translate.c b/target-s390x/translate.c
index 2013a81..0387806 100644
--- a/target-s390x/translate.c
+++ b/target-s390x/translate.c
@@ -249,6 +249,38 @@ static void update_psw_addr(DisasContext *s)
tcg_gen_movi_i64(psw_addr, s->pc);
}
+static void per_branch(DisasContext *s, bool to_next)
+{
+#ifndef CONFIG_USER_ONLY
+ if (s->tb->flags & FLAG_MASK_PER) {
+ TCGv_i64 pc = tcg_const_i64(s->pc);
+ TCGv_i64 next_pc = to_next ? tcg_const_i64(s->next_pc) : psw_addr;
+ gen_helper_per_branch(cpu_env, pc, next_pc);
+ if (to_next) {
+ tcg_temp_free_i64(next_pc);
+ }
+ tcg_temp_free_i64(pc);
+ }
+#endif
+}
+
+static void per_branch_cond(DisasContext *s, TCGCond cond,
+ TCGv_i64 arg1, TCGv_i64 arg2)
+{
+#ifndef CONFIG_USER_ONLY
+ if (s->tb->flags & FLAG_MASK_PER) {
+ TCGLabel *lab = gen_new_label();
+ tcg_gen_brcond_i64(tcg_invert_cond(cond), arg1, arg2, lab);
+
+ TCGv_i64 pc = tcg_const_i64(s->pc);
+ gen_helper_per_branch(cpu_env, pc, psw_addr);
+ tcg_temp_free_i64(pc);
+
+ gen_set_label(lab);
+ }
+#endif
+}
+
static void update_cc_op(DisasContext *s)
{
if (s->cc_op != CC_OP_DYNAMIC && s->cc_op != CC_OP_STATIC) {
@@ -1183,6 +1215,7 @@ static void help_l2_shift(DisasContext *s, DisasFields *f,
static ExitStatus help_goto_direct(DisasContext *s, uint64_t dest)
{
if (dest == s->next_pc) {
+ per_branch(s, true);
return NO_EXIT;
}
if (use_goto_tb(s, dest)) {
@@ -1193,6 +1226,7 @@ static ExitStatus help_goto_direct(DisasContext *s, uint64_t dest)
return EXIT_GOTO_TB;
} else {
tcg_gen_movi_i64(psw_addr, dest);
+ per_branch(s, false);
return EXIT_PC_UPDATED;
}
}
@@ -1212,6 +1246,7 @@ static ExitStatus help_branch(DisasContext *s, DisasCompare *c,
if (is_imm) {
if (dest == s->next_pc) {
/* Branch to next. */
+ per_branch(s, true);
ret = NO_EXIT;
goto egress;
}
@@ -1227,6 +1262,7 @@ static ExitStatus help_branch(DisasContext *s, DisasCompare *c,
}
if (c->cond == TCG_COND_ALWAYS) {
tcg_gen_mov_i64(psw_addr, cdest);
+ per_branch(s, false);
ret = EXIT_PC_UPDATED;
goto egress;
}
@@ -1297,6 +1333,7 @@ static ExitStatus help_branch(DisasContext *s, DisasCompare *c,
if (c->is_64) {
tcg_gen_movcond_i64(c->cond, psw_addr, c->u.s64.a, c->u.s64.b,
cdest, next);
+ per_branch_cond(s, c->cond, c->u.s64.a, c->u.s64.b);
} else {
TCGv_i32 t0 = tcg_temp_new_i32();
TCGv_i64 t1 = tcg_temp_new_i64();
@@ -1305,6 +1342,7 @@ static ExitStatus help_branch(DisasContext *s, DisasCompare *c,
tcg_gen_extu_i32_i64(t1, t0);
tcg_temp_free_i32(t0);
tcg_gen_movcond_i64(TCG_COND_NE, psw_addr, t1, z, cdest, next);
+ per_branch_cond(s, TCG_COND_NE, t1, z);
tcg_temp_free_i64(t1);
tcg_temp_free_i64(z);
}
@@ -1437,6 +1475,7 @@ static ExitStatus op_bas(DisasContext *s, DisasOps *o)
tcg_gen_movi_i64(o->out, pc_to_link_info(s, s->next_pc));
if (!TCGV_IS_UNUSED_I64(o->in2)) {
tcg_gen_mov_i64(psw_addr, o->in2);
+ per_branch(s, false);
return EXIT_PC_UPDATED;
} else {
return NO_EXIT;
--
1.7.12.4
next prev parent reply other threads:[~2015-06-17 10:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 10:42 [Qemu-devel] [PULL 00/26] s390 patch queue 2015-06-17 Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 01/26] s390/ioinst: fix IO_INT_WORD_ISC macro Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 02/26] s390/ioinst: fix endianness in ioinst_schib_valid Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 03/26] virtio-ccw: disable ioevent bit when ioeventfds are not enabled Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 04/26] target-s390x: fix setcc in TCG mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 05/26] target-s390x: correctly initialize ext interrupt queue Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 06/26] target-s390x: initialize I/O " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 07/26] target-s390x: fix s390_cpu_initial_reset Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 08/26] target-s390x: wire up DIAG IPL in TCG mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 09/26] target-s390x: wire up DIAG REIPL " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 10/26] target-s390x: wire up I/O instructions " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 11/26] softmmu: provide tlb_vaddr_to_host function for user mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 12/26] target-s390x: function to adjust the length wrt page boundary Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 13/26] target-s390x: mvc_fast_memset: access memory through softmmu Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 14/26] target-s390x: mvc_fast_memmove: " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 15/26] target-s390x: add PER related constants Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 16/26] target-s390x: add get_per_atmid function Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 17/26] target-s390x: add get_per_in_range function Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 18/26] target-s390x: basic PER event handling Alexander Graf
2015-06-17 10:43 ` Alexander Graf [this message]
2015-06-17 10:43 ` [Qemu-devel] [PULL 20/26] target-s390x: PER instruction-fetch event support Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 21/26] translate-all: fix watchpoints if retranslation not possible Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 22/26] target-s390x: PER storage-alteration event support Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 23/26] target-s390x: PER store-using-real-address " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 24/26] target-s390x: PER instruction-fetch nullification " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 25/26] target-s390x: PER: add Breaking-Event-Address register Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 26/26] s390x: Switch to s390-ccw machine as default Alexander Graf
2015-06-17 12:11 ` [Qemu-devel] [PULL 00/26] s390 patch queue 2015-06-17 Christian Borntraeger
2015-06-17 13:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434537789-63782-20-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).