From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 02/26] s390/ioinst: fix endianness in ioinst_schib_valid
Date: Wed, 17 Jun 2015 12:42:45 +0200 [thread overview]
Message-ID: <1434537789-63782-3-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1434537789-63782-1-git-send-email-agraf@suse.de>
The ioinst_schib_valid gets a SCHIB in guest endianness, we should
byteswap the fields we access.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
target-s390x/ioinst.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-s390x/ioinst.c b/target-s390x/ioinst.c
index e220cea..77f2a1f 100644
--- a/target-s390x/ioinst.c
+++ b/target-s390x/ioinst.c
@@ -129,12 +129,12 @@ void ioinst_handle_hsch(S390CPU *cpu, uint64_t reg1)
static int ioinst_schib_valid(SCHIB *schib)
{
- if ((schib->pmcw.flags & PMCW_FLAGS_MASK_INVALID) ||
- (schib->pmcw.chars & PMCW_CHARS_MASK_INVALID)) {
+ if ((be16_to_cpu(schib->pmcw.flags) & PMCW_FLAGS_MASK_INVALID) ||
+ (be32_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_INVALID)) {
return 0;
}
/* Disallow extended measurements for now. */
- if (schib->pmcw.chars & PMCW_CHARS_MASK_XMWME) {
+ if (be32_to_cpu(schib->pmcw.chars) & PMCW_CHARS_MASK_XMWME) {
return 0;
}
return 1;
--
1.7.12.4
next prev parent reply other threads:[~2015-06-17 10:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 10:42 [Qemu-devel] [PULL 00/26] s390 patch queue 2015-06-17 Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 01/26] s390/ioinst: fix IO_INT_WORD_ISC macro Alexander Graf
2015-06-17 10:42 ` Alexander Graf [this message]
2015-06-17 10:42 ` [Qemu-devel] [PULL 03/26] virtio-ccw: disable ioevent bit when ioeventfds are not enabled Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 04/26] target-s390x: fix setcc in TCG mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 05/26] target-s390x: correctly initialize ext interrupt queue Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 06/26] target-s390x: initialize I/O " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 07/26] target-s390x: fix s390_cpu_initial_reset Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 08/26] target-s390x: wire up DIAG IPL in TCG mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 09/26] target-s390x: wire up DIAG REIPL " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 10/26] target-s390x: wire up I/O instructions " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 11/26] softmmu: provide tlb_vaddr_to_host function for user mode Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 12/26] target-s390x: function to adjust the length wrt page boundary Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 13/26] target-s390x: mvc_fast_memset: access memory through softmmu Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 14/26] target-s390x: mvc_fast_memmove: " Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 15/26] target-s390x: add PER related constants Alexander Graf
2015-06-17 10:42 ` [Qemu-devel] [PULL 16/26] target-s390x: add get_per_atmid function Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 17/26] target-s390x: add get_per_in_range function Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 18/26] target-s390x: basic PER event handling Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 19/26] target-s390x: PER successful-branching event support Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 20/26] target-s390x: PER instruction-fetch " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 21/26] translate-all: fix watchpoints if retranslation not possible Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 22/26] target-s390x: PER storage-alteration event support Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 23/26] target-s390x: PER store-using-real-address " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 24/26] target-s390x: PER instruction-fetch nullification " Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 25/26] target-s390x: PER: add Breaking-Event-Address register Alexander Graf
2015-06-17 10:43 ` [Qemu-devel] [PULL 26/26] s390x: Switch to s390-ccw machine as default Alexander Graf
2015-06-17 12:11 ` [Qemu-devel] [PULL 00/26] s390 patch queue 2015-06-17 Christian Borntraeger
2015-06-17 13:03 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434537789-63782-3-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).