From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
=?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@fr.ibm.com>
Subject: [Qemu-devel] [PULL 07/10] vhost_net: re-enable when cross endian
Date: Wed, 17 Jun 2015 21:38:21 +0200 [thread overview]
Message-ID: <1434569795-10524-8-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1434569795-10524-1-git-send-email-mst@redhat.com>
From: Cédric Le Goater <clg@fr.ibm.com>
Cross-endianness is now checked by the core vhost code.
revert 371df9f5e0f1 "vhost-net: disable when cross-endian"
Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
[ added commit message, Greg Kurz <gkurz@linux.vnet.ibm.com> ]
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/net/vhost_net.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 8cbb2f6..f505c91 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -303,19 +303,6 @@ static void vhost_net_stop_one(struct vhost_net *net,
vhost_dev_disable_notifiers(&net->dev, dev);
}
-static bool vhost_net_device_endian_ok(VirtIODevice *vdev)
-{
-#ifdef TARGET_IS_BIENDIAN
-#ifdef HOST_WORDS_BIGENDIAN
- return virtio_is_big_endian(vdev);
-#else
- return !virtio_is_big_endian(vdev);
-#endif
-#else
- return true;
-#endif
-}
-
int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
int total_queues)
{
@@ -324,12 +311,6 @@ int vhost_net_start(VirtIODevice *dev, NetClientState *ncs,
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
int r, e, i;
- if (!vhost_net_device_endian_ok(dev)) {
- error_report("vhost-net does not support cross-endian");
- r = -ENOSYS;
- goto err;
- }
-
if (!k->set_guest_notifiers) {
error_report("binding does not support guest notifiers");
r = -ENOSYS;
--
MST
next prev parent reply other threads:[~2015-06-17 19:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 19:38 [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 01/10] vhost-user: part of virtio Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 02/10] linux-headers: sync vhost.h Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 03/10] virtio: introduce virtio_legacy_is_cross_endian() Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 04/10] vhost: set vring endianness for legacy virtio Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 05/10] tap: add VNET_LE/VNET_BE operations Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 06/10] vhost-net: tell tap backend about the vnet endianness Michael S. Tsirkin
2015-06-17 19:38 ` Michael S. Tsirkin [this message]
2015-06-17 19:38 ` [Qemu-devel] [PULL 08/10] hw/core: rebase sysbus_get_fw_dev_path() to g_strdup_printf() Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 09/10] pci: Don't register a specialized 'config_write' if default behavior is intended Michael S. Tsirkin
2015-06-17 19:38 ` [Qemu-devel] [PULL 10/10] vhost: enable vhost without without MSI-X Michael S. Tsirkin
2015-06-18 10:36 ` [Qemu-devel] [PULL 00/10] virtio, pci fixes, enhancements Peter Maydell
2015-06-18 11:14 ` Michael S. Tsirkin
2015-06-18 16:29 ` Peter Maydell
2015-06-19 7:30 ` Michael S. Tsirkin
2015-06-19 8:32 ` Peter Maydell
2015-06-19 10:19 ` Michael S. Tsirkin
2015-06-19 11:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434569795-10524-8-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=clg@fr.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).