From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5JAI-0005Ie-T2 for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:38:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5JAG-0001hv-Li for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:38:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5JAG-0001hb-Fr for qemu-devel@nongnu.org; Wed, 17 Jun 2015 15:38:24 -0400 Date: Wed, 17 Jun 2015 21:38:21 +0200 From: "Michael S. Tsirkin" Message-ID: <1434569795-10524-8-git-send-email-mst@redhat.com> References: <1434569795-10524-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1434569795-10524-1-git-send-email-mst@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 07/10] vhost_net: re-enable when cross endian List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , =?us-ascii?B?PT9VVEYtOD9xP0M9QzM9QTlkcmljPTIwTGU9MjBHb2F0ZXI/PQ==?= From: C=E9dric Le Goater Cross-endianness is now checked by the core vhost code. revert 371df9f5e0f1 "vhost-net: disable when cross-endian" Signed-off-by: C=E9dric Le Goater [ added commit message, Greg Kurz ] Signed-off-by: Greg Kurz Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/net/vhost_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 8cbb2f6..f505c91 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -303,19 +303,6 @@ static void vhost_net_stop_one(struct vhost_net *net= , vhost_dev_disable_notifiers(&net->dev, dev); } =20 -static bool vhost_net_device_endian_ok(VirtIODevice *vdev) -{ -#ifdef TARGET_IS_BIENDIAN -#ifdef HOST_WORDS_BIGENDIAN - return virtio_is_big_endian(vdev); -#else - return !virtio_is_big_endian(vdev); -#endif -#else - return true; -#endif -} - int vhost_net_start(VirtIODevice *dev, NetClientState *ncs, int total_queues) { @@ -324,12 +311,6 @@ int vhost_net_start(VirtIODevice *dev, NetClientStat= e *ncs, VirtioBusClass *k =3D VIRTIO_BUS_GET_CLASS(vbus); int r, e, i; =20 - if (!vhost_net_device_endian_ok(dev)) { - error_report("vhost-net does not support cross-endian"); - r =3D -ENOSYS; - goto err; - } - if (!k->set_guest_notifiers) { error_report("binding does not support guest notifiers"); r =3D -ENOSYS; --=20 MST