From: Wen Congyang <wency@cn.fujitsu.com>
To: qemu devel <qemu-devel@nongnu.org>, Fam Zheng <famz@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu block <qemu-block@nongnu.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: [Qemu-devel] [PATCH COLO-Block v6 10/16] NBD client: connect to nbd server later
Date: Thu, 18 Jun 2015 16:49:15 +0800 [thread overview]
Message-ID: <1434617361-17778-11-git-send-email-wency@cn.fujitsu.com> (raw)
In-Reply-To: <1434617361-17778-1-git-send-email-wency@cn.fujitsu.com>
The secondary qemu starts later than the primary qemu, so we
cannot connect to nbd server in bdrv_open(). Introduce a new
open flags to control it.
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
block/nbd.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index bc9477a..4964cf8 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -298,11 +298,13 @@ static int nbd_open(BlockDriverState *bs, QDict *options, int flags,
return -EINVAL;
}
- nbd_connect_server(bs, &local_err);
- if (local_err) {
- error_propagate(errp, local_err);
- g_free(s->export);
- return -EINVAL;
+ if (!(flags & BDRV_O_NO_CONNECT)) {
+ nbd_connect_server(bs, &local_err);
+ if (local_err) {
+ error_propagate(errp, local_err);
+ g_free(s->export);
+ return -EINVAL;
+ }
}
return 0;
--
2.4.3
next prev parent reply other threads:[~2015-06-18 8:45 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 8:49 [Qemu-devel] [PATCH COLO-Block v6 00/16] Block replication for continuous checkpoints Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 01/16] docs: block replication's description Wen Congyang
2015-06-18 10:34 ` Stefan Hajnoczi
2015-06-18 10:51 ` Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 02/16] allow writing to the backing file Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 03/16] Allow creating backup jobs when opening BDS Wen Congyang
2015-06-18 10:40 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse "backing_reference" option to reference existing BDS Wen Congyang
2015-06-18 10:50 ` Stefan Hajnoczi
2015-06-18 11:40 ` Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 05/16] Backup: clear all bitmap when doing block checkpoint Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 06/16] Don't allow a disk use backing reference target Wen Congyang
2015-06-18 12:47 ` Stefan Hajnoczi
2015-06-18 15:17 ` Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target Wen Congyang
2015-06-18 12:55 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-06-18 14:36 ` Wen Congyang
2015-06-18 16:06 ` Stefan Hajnoczi
2015-06-19 0:54 ` Wen Congyang
2015-06-19 10:49 ` Stefan Hajnoczi
2015-06-20 3:31 ` Wen Congyang
2015-06-22 12:39 ` Stefan Hajnoczi
2015-06-22 13:56 ` Wen Congyang
2015-06-23 13:42 ` Stefan Hajnoczi
2015-06-23 13:54 ` Wen Congyang
2015-06-24 14:07 ` Dr. David Alan Gilbert
2015-06-25 1:01 ` Wen Congyang
2015-06-26 19:03 ` Dr. David Alan Gilbert
2015-06-29 1:05 ` Wen Congyang
2015-06-30 19:01 ` Dr. David Alan Gilbert
2015-07-01 1:01 ` Wen Congyang
2015-07-01 8:11 ` Dr. David Alan Gilbert
2015-07-01 8:18 ` Wen Congyang
2015-07-01 18:42 ` Dr. David Alan Gilbert
2015-07-02 0:55 ` Wen Congyang
2015-07-02 7:54 ` Dr. David Alan Gilbert
2015-07-02 8:05 ` Wen Congyang
2015-06-24 1:11 ` Wen Congyang
2015-06-23 6:44 ` Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 08/16] NBD client: implement block driver interfaces to connect/disconnect NBD server Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 09/16] Introduce a new -drive option to control whether to connect to remote target Wen Congyang
2015-06-18 8:49 ` Wen Congyang [this message]
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 11/16] Add new block driver interfaces to control block replication Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 12/16] skip nbd_target when starting " Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 13/16] quorum: implement block driver interfaces for " Wen Congyang
2015-06-18 13:06 ` Stefan Hajnoczi
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 14/16] introduce a new API qemu_opts_absorb_qdict_by_index() Wen Congyang
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 15/16] quorum: allow ignoring child errors Wen Congyang
2015-06-18 13:06 ` Stefan Hajnoczi
2015-06-18 8:49 ` [Qemu-devel] [PATCH COLO-Block v6 16/16] Implement new driver for block replication Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434617361-17778-11-git-send-email-wency@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=arei.gonglei@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).