From: "Radim Krčmář" <rkrcmar@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, bsd@redhat.com, ehabkost@redhat.com,
rth@twiddle.net
Subject: [Qemu-devel] [PATCH 2/2] target-i386: automatically raise cpuid level to 0xd
Date: Thu, 18 Jun 2015 17:24:24 +0200 [thread overview]
Message-ID: <1434641064-8405-3-git-send-email-rkrcmar@redhat.com> (raw)
In-Reply-To: <1434641064-8405-1-git-send-email-rkrcmar@redhat.com>
We already bump to level 7 if features there are requested, so do the
same for 0xD.
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
If we want this behavior, we should not do it by writing a case for
every level.
target-i386/cpu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index d392cf46f517..7a32ead690d2 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2796,6 +2796,10 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
env->cpuid_level = 7;
}
+ if (env->features[FEAT_XSAVE] && env->cpuid_level < 0xd) {
+ env->cpuid_level = 0xd;
+ }
+
/* On AMD CPUs, some CPUID[8000_0001].EDX bits must match the bits on
* CPUID[1].EDX.
*/
--
2.4.4
next prev parent reply other threads:[~2015-06-18 15:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 15:24 [Qemu-devel] [PATCH 0/2] target-i386: fix W10 bug and bring CPUID levels closer to reality Radim Krčmář
2015-06-18 15:24 ` [Qemu-devel] [PATCH 1/2] target-i386: emulate CPUID level of real hardware Radim Krčmář
2015-06-18 15:29 ` Paolo Bonzini
2015-06-18 15:40 ` Radim Krčmář
2015-06-18 15:42 ` Paolo Bonzini
2015-06-18 17:26 ` Bandan Das
2015-06-18 15:24 ` Radim Krčmář [this message]
2015-06-18 15:50 ` [Qemu-devel] [PATCH 2/2] target-i386: automatically raise cpuid level to 0xd Eduardo Habkost
2015-06-18 17:12 ` Bandan Das
2015-06-18 17:26 ` Eduardo Habkost
2015-06-19 9:47 ` Radim Krčmář
2015-06-19 9:54 ` Radim Krčmář
2015-06-19 11:28 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434641064-8405-3-git-send-email-rkrcmar@redhat.com \
--to=rkrcmar@redhat.com \
--cc=bsd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).