From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5c8s-0001RN-9h for qemu-devel@nongnu.org; Thu, 18 Jun 2015 11:54:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5c8o-0000qm-Vk for qemu-devel@nongnu.org; Thu, 18 Jun 2015 11:54:14 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:46560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5c8o-0000qD-L3 for qemu-devel@nongnu.org; Thu, 18 Jun 2015 11:54:10 -0400 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Jun 2015 16:54:09 +0100 From: Christian Borntraeger Date: Thu, 18 Jun 2015 17:54:28 +0200 Message-Id: <1434642868-18685-1-git-send-email-borntraeger@de.ibm.com> Subject: [Qemu-devel] [PATCH/RFC] s390x/ipl: Fix boot if no bootindex was specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel Cc: qemu-stable@nongnu.org, Alexander Graf , Christian Borntraeger , v2.3.0@tuxmaker.boeblingen.de.ibm.com, #@tuxmaker.boeblingen.de.ibm.com, Cornelia Huck , Paolo Bonzini , Aurelien Jarno commit fa92e218df1d ("s390x/ipl: avoid sign extension") introduced a regression: qemu-system-s390x -drive file=/home/cborntra/image.zhyp409,format=qcow2 does not boot, the bios states "No virtio-blk device found!" adding bootindex=1 does boot. The reason is that the uint32_t as return value will not do the right thing for the return -1 (default without bootindex). The bios itself, will interpret a 64bit -1 as autodetect (but it will interpret 32bit -1 as ccw device address ff.ff.ffff) Signed-off-by: Christian Borntraeger Cc: Paolo Bonzini Cc: Cornelia Huck Cc: qemu-stable@nongnu.org # v2.3.0 --- hw/s390x/ipl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 132004a..2e0a8b6 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -218,7 +218,7 @@ static Property s390_ipl_properties[] = { * - -1 if no valid boot device was found * - ccw id of the boot device otherwise */ -static uint32_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl) +static uint64_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl) { DeviceState *dev_st; @@ -248,7 +248,7 @@ static uint32_t s390_update_iplstate(CPUS390XState *env, S390IPLState *ipl) return -1; out: - return ipl->cssid << 24 | ipl->ssid << 16 | ipl->devno; + return (uint32_t) (ipl->cssid << 24 | ipl->ssid << 16 | ipl->devno); } int s390_ipl_update_diag308(IplParameterBlock *iplb) -- 2.3.0