From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5mEN-0004d1-Fx for qemu-devel@nongnu.org; Thu, 18 Jun 2015 22:40:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5mEK-0004Kt-8y for qemu-devel@nongnu.org; Thu, 18 Jun 2015 22:40:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5mEK-0004Kj-3U for qemu-devel@nongnu.org; Thu, 18 Jun 2015 22:40:32 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id BA94E37FF50 for ; Fri, 19 Jun 2015 02:40:31 +0000 (UTC) From: Laszlo Ersek Date: Fri, 19 Jun 2015 04:40:11 +0200 Message-Id: <1434681617-15539-5-git-send-email-lersek@redhat.com> In-Reply-To: <1434681617-15539-1-git-send-email-lersek@redhat.com> References: <1434681617-15539-1-git-send-email-lersek@redhat.com> Subject: [Qemu-devel] [PATCH v7 04/10] hw/pci-bridge: add macro for "msi" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, lersek@redhat.com Cc: Marcel Apfelbaum , "Michael S. Tsirkin" This should help catch property name typos at compile time. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Laszlo Ersek --- Notes: v7: - new in v7 include/hw/pci/pci_bridge.h | 1 + hw/pci-bridge/pci_bridge_dev.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h index f3ac49f..a438eda 100644 --- a/include/hw/pci/pci_bridge.h +++ b/include/hw/pci/pci_bridge.h @@ -29,6 +29,7 @@ #include "hw/pci/pci.h" #define PCI_BRIDGE_DEV_PROP_CHASSIS_NR "chassis_nr" +#define PCI_BRIDGE_DEV_PROP_MSI "msi" int pci_bridge_ssvid_init(PCIDevice *dev, uint8_t offset, uint16_t svid, uint16_t ssid); diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index f669ecd..6b99f08 100644 --- a/hw/pci-bridge/pci_bridge_dev.c +++ b/hw/pci-bridge/pci_bridge_dev.c @@ -124,7 +124,8 @@ static Property pci_bridge_dev_properties[] = { /* Note: 0 is not a legal chassis number. */ DEFINE_PROP_UINT8(PCI_BRIDGE_DEV_PROP_CHASSIS_NR, PCIBridgeDev, chassis_nr, 0), - DEFINE_PROP_BIT("msi", PCIBridgeDev, flags, PCI_BRIDGE_DEV_F_MSI_REQ, true), + DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, flags, + PCI_BRIDGE_DEV_F_MSI_REQ, true), DEFINE_PROP_END_OF_LIST(), }; -- 1.8.3.1