* [Qemu-devel] [PATCH] tap: fix non-linux build
@ 2015-06-19 7:44 Michael S. Tsirkin
2015-06-19 8:16 ` Thomas Huth
2015-06-19 9:26 ` Greg Kurz
0 siblings, 2 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2015-06-19 7:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Jason Wang, Stefan Hajnoczi
tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing,
fix it up.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
net/tap-aix.c | 10 ++++++++++
net/tap-bsd.c | 10 ++++++++++
net/tap-haiku.c | 10 ++++++++++
net/tap-solaris.c | 10 ++++++++++
net/tap-win32.c | 10 ++++++++++
5 files changed, 50 insertions(+)
diff --git a/net/tap-aix.c b/net/tap-aix.c
index 18fdbf3..e84fc39 100644
--- a/net/tap-aix.c
+++ b/net/tap-aix.c
@@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
{
}
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+ return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+ return -EINVAL;
+}
+
void tap_fd_set_offload(int fd, int csum, int tso4,
int tso6, int ecn, int ufo)
{
diff --git a/net/tap-bsd.c b/net/tap-bsd.c
index 5889920..7028d9b 100644
--- a/net/tap-bsd.c
+++ b/net/tap-bsd.c
@@ -196,6 +196,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
{
}
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+ return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+ return -EINVAL;
+}
+
void tap_fd_set_offload(int fd, int csum, int tso4,
int tso6, int ecn, int ufo)
{
diff --git a/net/tap-haiku.c b/net/tap-haiku.c
index d18590c..2e738ec 100644
--- a/net/tap-haiku.c
+++ b/net/tap-haiku.c
@@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
{
}
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+ return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+ return -EINVAL;
+}
+
void tap_fd_set_offload(int fd, int csum, int tso4,
int tso6, int ecn, int ufo)
{
diff --git a/net/tap-solaris.c b/net/tap-solaris.c
index 90b2fd1..0f60f78 100644
--- a/net/tap-solaris.c
+++ b/net/tap-solaris.c
@@ -223,6 +223,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
{
}
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+ return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+ return -EINVAL;
+}
+
void tap_fd_set_offload(int fd, int csum, int tso4,
int tso6, int ecn, int ufo)
{
diff --git a/net/tap-win32.c b/net/tap-win32.c
index f6fc961..625d53c 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
@@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
{
}
+int tap_fd_set_vnet_le(int fd, int is_le)
+{
+ return -EINVAL;
+}
+
+int tap_fd_set_vnet_be(int fd, int is_be)
+{
+ return -EINVAL;
+}
+
static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
{
}
--
MST
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tap: fix non-linux build
2015-06-19 7:44 [Qemu-devel] [PATCH] tap: fix non-linux build Michael S. Tsirkin
@ 2015-06-19 8:16 ` Thomas Huth
2015-06-19 9:26 ` Greg Kurz
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2015-06-19 8:16 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Jason Wang, qemu-devel, Stefan Hajnoczi
On Fri, 19 Jun 2015 09:44:00 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing,
> fix it up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> net/tap-aix.c | 10 ++++++++++
> net/tap-bsd.c | 10 ++++++++++
> net/tap-haiku.c | 10 ++++++++++
> net/tap-solaris.c | 10 ++++++++++
> net/tap-win32.c | 10 ++++++++++
> 5 files changed, 50 insertions(+)
>
> diff --git a/net/tap-aix.c b/net/tap-aix.c
> index 18fdbf3..e84fc39 100644
> --- a/net/tap-aix.c
> +++ b/net/tap-aix.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-bsd.c b/net/tap-bsd.c
> index 5889920..7028d9b 100644
> --- a/net/tap-bsd.c
> +++ b/net/tap-bsd.c
> @@ -196,6 +196,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-haiku.c b/net/tap-haiku.c
> index d18590c..2e738ec 100644
> --- a/net/tap-haiku.c
> +++ b/net/tap-haiku.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-solaris.c b/net/tap-solaris.c
> index 90b2fd1..0f60f78 100644
> --- a/net/tap-solaris.c
> +++ b/net/tap-solaris.c
> @@ -223,6 +223,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index f6fc961..625d53c 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
> {
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tap: fix non-linux build
2015-06-19 7:44 [Qemu-devel] [PATCH] tap: fix non-linux build Michael S. Tsirkin
2015-06-19 8:16 ` Thomas Huth
@ 2015-06-19 9:26 ` Greg Kurz
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kurz @ 2015-06-19 9:26 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Jason Wang, qemu-devel, Stefan Hajnoczi
On Fri, 19 Jun 2015 09:44:00 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> tap_fd_set_vnet_le/tap_fd_set_vnet_be was missing,
> fix it up.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> net/tap-aix.c | 10 ++++++++++
> net/tap-bsd.c | 10 ++++++++++
> net/tap-haiku.c | 10 ++++++++++
> net/tap-solaris.c | 10 ++++++++++
> net/tap-win32.c | 10 ++++++++++
> 5 files changed, 50 insertions(+)
>
> diff --git a/net/tap-aix.c b/net/tap-aix.c
> index 18fdbf3..e84fc39 100644
> --- a/net/tap-aix.c
> +++ b/net/tap-aix.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-bsd.c b/net/tap-bsd.c
> index 5889920..7028d9b 100644
> --- a/net/tap-bsd.c
> +++ b/net/tap-bsd.c
> @@ -196,6 +196,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-haiku.c b/net/tap-haiku.c
> index d18590c..2e738ec 100644
> --- a/net/tap-haiku.c
> +++ b/net/tap-haiku.c
> @@ -55,6 +55,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-solaris.c b/net/tap-solaris.c
> index 90b2fd1..0f60f78 100644
> --- a/net/tap-solaris.c
> +++ b/net/tap-solaris.c
> @@ -223,6 +223,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> void tap_fd_set_offload(int fd, int csum, int tso4,
> int tso6, int ecn, int ufo)
> {
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index f6fc961..625d53c 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -688,6 +688,16 @@ void tap_fd_set_vnet_hdr_len(int fd, int len)
> {
> }
>
> +int tap_fd_set_vnet_le(int fd, int is_le)
> +{
> + return -EINVAL;
> +}
> +
> +int tap_fd_set_vnet_be(int fd, int is_be)
> +{
> + return -EINVAL;
> +}
> +
> static void tap_using_vnet_hdr(NetClientState *nc, bool using_vnet_hdr)
> {
> }
I couldn't setup a build environment on a non-linux platform (tried AIX
but I miss to many packages), so I won't give a Tested-by... patch is trivial
though so:
Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-19 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-19 7:44 [Qemu-devel] [PATCH] tap: fix non-linux build Michael S. Tsirkin
2015-06-19 8:16 ` Thomas Huth
2015-06-19 9:26 ` Greg Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).