From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 0/1] vvfat label option updated
Date: Fri, 19 Jun 2015 11:35:28 +0200 [thread overview]
Message-ID: <1434706529-13895-1-git-send-email-w.bumiller@proxmox.com> (raw)
* Till/Until changed
* Added (since 2.4) to json file
* Added the 11-byte limit description. Without mentioning the trailing
spaces in the json file since the guest OS doesn't expose them to
the user. However, I mentioned it in the commit message.
The limit comes from the FAT structure, but for completeness' sake I
looked up the FAT descriptions a little more. Turns out at least
FAT32 labels are "supposed" to be stored with uppercase letters, and
seem to have some theoretical restrictions on the used characters, but
neither linux nor windows guests seem to care on the OS side. And at
least mkfs.vfat's -n option only warns about lowercase letters, but
doesn't error. Theoretically you're also not allowed to start a label
with a space, while mkfs.vfat neither warns nor errors about this.
So I decided to not add any additional checks and only mentioned it in
the json's doc string.
Wolfgang Bumiller (1):
vvfat: add a label option
block/vvfat.c | 25 ++++++++++++++++++++++---
qapi/block-core.json | 6 +++++-
2 files changed, 27 insertions(+), 4 deletions(-)
--
2.1.4
next reply other threads:[~2015-06-19 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 9:35 Wolfgang Bumiller [this message]
2015-06-19 9:35 ` [Qemu-devel] [PATCH v2 1/1] vvfat: add a label option Wolfgang Bumiller
2015-06-19 12:48 ` Eric Blake
2015-06-19 12:50 ` [Qemu-devel] [PATCH v2 0/1] vvfat label option updated Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434706529-13895-1-git-send-email-w.bumiller@proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).