From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v1 15/16] s3adsp1800: Remove the hardcoded values from the reset
Date: Sun, 21 Jun 2015 21:56:26 +1000 [thread overview]
Message-ID: <1434887787-4188-16-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1434887787-4188-1-git-send-email-edgar.iglesias@gmail.com>
From: Alistair Francis <alistair.francis@xilinx.com>
Remove the hardcoded values from the machine specific reset
function, as the same values are already set in the standard
MicroBlaze reset.
This also allows the entire reset function to be deleted, as
PVR registers are now preserved on reset.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/microblaze/petalogix_s3adsp1800_mmu.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petalogix_s3adsp1800_mmu.c
index 4dbbd1e..0c2140c 100644
--- a/hw/microblaze/petalogix_s3adsp1800_mmu.c
+++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
@@ -51,13 +51,6 @@
#define ETHLITE_IRQ 1
#define UARTLITE_IRQ 3
-static void machine_cpu_reset(MicroBlazeCPU *cpu)
-{
- CPUMBState *env = &cpu->env;
-
- env->pvr.regs[10] = 0x0c000000; /* spartan 3a dsp family. */
-}
-
static void
petalogix_s3adsp1800_init(MachineState *machine)
{
@@ -128,7 +121,7 @@ petalogix_s3adsp1800_init(MachineState *machine)
microblaze_load_kernel(cpu, ddr_base, ram_size,
machine->initrd_filename,
BINARY_DEVICE_TREE_FILE,
- machine_cpu_reset);
+ NULL);
}
static QEMUMachine petalogix_s3adsp1800_machine = {
--
1.9.1
next prev parent reply other threads:[~2015-06-21 12:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 11:56 [Qemu-devel] [PATCH v1 00/16] Microblaze Queue Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 01/16] microblaze: s3adsp: Instantiate CPU using QOM Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 02/16] target-microblaze: Fix up indentation Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 03/16] target-microblaze: Preserve the pvr registers during reset Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 05/16] target-microblaze: Tidy up the base-vectors property Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 06/16] target-microblaze: Convert use-fpu to a CPU property Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 07/16] target-microblaze: Disable stack protection by default Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 08/16] target-microblaze: Rename the usefpu variable Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 11/16] target-microblaze: Convert endi to a CPU property Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 12/16] target-microblaze: Convert version_mask " Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 13/16] target-microblaze: Convert pvr-full " Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 14/16] ml605_mmu: Move the hardcoded values to the init function Edgar E. Iglesias
2015-06-21 11:56 ` Edgar E. Iglesias [this message]
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 16/16] target-microblaze: Remove dead code Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434887787-4188-16-git-send-email-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).