qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v1 01/16] microblaze: s3adsp: Instantiate CPU using QOM
Date: Sun, 21 Jun 2015 21:56:12 +1000	[thread overview]
Message-ID: <1434887787-4188-2-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1434887787-4188-1-git-send-email-edgar.iglesias@gmail.com>

From: Peter Crosthwaite <crosthwaitepeter@gmail.com>

Instantiate and realise the CPU directly, rather than using
cpu_mb_init. Microblazes cpu_model argument is a dummy so remove the
default cpu_model set logic.

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 hw/microblaze/petalogix_s3adsp1800_mmu.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/hw/microblaze/petalogix_s3adsp1800_mmu.c b/hw/microblaze/petalogix_s3adsp1800_mmu.c
index 84f6e74..4dbbd1e 100644
--- a/hw/microblaze/petalogix_s3adsp1800_mmu.c
+++ b/hw/microblaze/petalogix_s3adsp1800_mmu.c
@@ -62,7 +62,6 @@ static void
 petalogix_s3adsp1800_init(MachineState *machine)
 {
     ram_addr_t ram_size = machine->ram_size;
-    const char *cpu_model = machine->cpu_model;
     DeviceState *dev;
     MicroBlazeCPU *cpu;
     DriveInfo *dinfo;
@@ -73,11 +72,8 @@ petalogix_s3adsp1800_init(MachineState *machine)
     qemu_irq irq[32];
     MemoryRegion *sysmem = get_system_memory();
 
-    /* init CPUs */
-    if (cpu_model == NULL) {
-        cpu_model = "microblaze";
-    }
-    cpu = cpu_mb_init(cpu_model);
+    cpu = MICROBLAZE_CPU(object_new(TYPE_MICROBLAZE_CPU));
+    object_property_set_bool(OBJECT(cpu), true, "realized", &error_abort);
 
     /* Attach emulated BRAM through the LMB.  */
     memory_region_init_ram(phys_lmb_bram, NULL,
-- 
1.9.1

  reply	other threads:[~2015-06-21 12:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-21 11:56 [Qemu-devel] [PATCH v1 00/16] Microblaze Queue Edgar E. Iglesias
2015-06-21 11:56 ` Edgar E. Iglesias [this message]
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 02/16] target-microblaze: Fix up indentation Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 03/16] target-microblaze: Preserve the pvr registers during reset Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 05/16] target-microblaze: Tidy up the base-vectors property Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 06/16] target-microblaze: Convert use-fpu to a CPU property Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 07/16] target-microblaze: Disable stack protection by default Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 08/16] target-microblaze: Rename the usefpu variable Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 11/16] target-microblaze: Convert endi to a CPU property Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 12/16] target-microblaze: Convert version_mask " Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 13/16] target-microblaze: Convert pvr-full " Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 14/16] ml605_mmu: Move the hardcoded values to the init function Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 15/16] s3adsp1800: Remove the hardcoded values from the reset Edgar E. Iglesias
2015-06-21 11:56 ` [Qemu-devel] [PATCH v1 16/16] target-microblaze: Remove dead code Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434887787-4188-2-git-send-email-edgar.iglesias@gmail.com \
    --to=edgar.iglesias@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).