From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z771e-0005aZ-6n for qemu-devel@nongnu.org; Mon, 22 Jun 2015 15:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z771c-0002Mn-DZ for qemu-devel@nongnu.org; Mon, 22 Jun 2015 15:04:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z771c-0002Mc-7r for qemu-devel@nongnu.org; Mon, 22 Jun 2015 15:04:56 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id E5EA2BACAB for ; Mon, 22 Jun 2015 19:04:55 +0000 (UTC) From: Markus Armbruster Date: Mon, 22 Jun 2015 21:04:31 +0200 Message-Id: <1434999889-849-7-git-send-email-armbru@redhat.com> In-Reply-To: <1434999889-849-1-git-send-email-armbru@redhat.com> References: <1434999889-849-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PULL 06/24] monitor: Fix failure path for "S" argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bandan Das From: Bandan Das Since the "S" argument type is only used with the "?" flag, the bug can't bite. Signed-off-by: Bandan Das Acked-by: Luiz Capitulino Signed-off-by: Markus Armbruster --- monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 4c7faf9..8b1dbf8 100644 --- a/monitor.c +++ b/monitor.c @@ -4016,7 +4016,7 @@ static QDict *monitor_parse_arguments(Monitor *mon, if (len <= 0) { monitor_printf(mon, "%s: string expected\n", cmd->name); - break; + goto fail; } qdict_put(qdict, key, qstring_from_str(p)); p += len; -- 1.9.3