From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z79fx-00035x-5l for qemu-devel@nongnu.org; Mon, 22 Jun 2015 17:54:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z79ft-0007Ye-To for qemu-devel@nongnu.org; Mon, 22 Jun 2015 17:54:45 -0400 Received: from mail-la0-x233.google.com ([2a00:1450:4010:c03::233]:33328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z79ft-0007X8-Lb for qemu-devel@nongnu.org; Mon, 22 Jun 2015 17:54:41 -0400 Received: by laka10 with SMTP id a10so118389540lak.0 for ; Mon, 22 Jun 2015 14:54:40 -0700 (PDT) From: Zavadovsky Yan Date: Tue, 23 Jun 2015 00:54:15 +0300 Message-Id: <1435010055-4584-1-git-send-email-zavadovsky.yan@gmail.com> Subject: [Qemu-devel] [PATCH] thread-win32: fix GetThreadContext() permanently fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: sw@weilnetz.de, Zavadovsky Yan , pbonzini@redhat.com Calling SuspendThread() is not enough to suspend Win32 thread. We need to call GetThreadContext() after SuspendThread() to make sure that OS have really suspended target thread. But GetThreadContext() needs for THREAD_GET_CONTEXT access right on thread object. This patch adds THREAD_GET_CONTEXT to OpenThread() arguments and change 'while(GetThreadContext() == SUCCESS)' to 'while(GetThreadContext() == FAILED)'. So this 'while' loop will stop only after successful grabbing of thread context(i.e. when thread is really suspended). Not after the one failed GetThreadContext() call. Signed-off-by: Zavadovsky Yan --- cpus.c | 2 +- util/qemu-thread-win32.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index b85fb5f..83d5eb5 100644 --- a/cpus.c +++ b/cpus.c @@ -1097,7 +1097,7 @@ static void qemu_cpu_kick_thread(CPUState *cpu) * suspended until we can get the context. */ tcgContext.ContextFlags = CONTEXT_CONTROL; - while (GetThreadContext(cpu->hThread, &tcgContext) != 0) { + while (GetThreadContext(cpu->hThread, &tcgContext) == 0) { continue; } diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c index 406b52f..823eca1 100644 --- a/util/qemu-thread-win32.c +++ b/util/qemu-thread-win32.c @@ -406,8 +406,8 @@ HANDLE qemu_thread_get_handle(QemuThread *thread) EnterCriticalSection(&data->cs); if (!data->exited) { - handle = OpenThread(SYNCHRONIZE | THREAD_SUSPEND_RESUME, FALSE, - thread->tid); + handle = OpenThread(SYNCHRONIZE | THREAD_SUSPEND_RESUME | THREAD_GET_CONTEXT, + FALSE, thread->tid); } else { handle = NULL; } -- 2.4.4.windows.2