From: Gerd Hoffmann <kraxel@redhat.com>
To: arei.gonglei@huawei.com
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] qdev: fix OVERFLOW_BEFORE_WIDEN
Date: Tue, 23 Jun 2015 09:48:23 +0200 [thread overview]
Message-ID: <1435045703.10077.47.camel@redhat.com> (raw)
In-Reply-To: <1435024385-9084-3-git-send-email-arei.gonglei@huawei.com>
On Di, 2015-06-23 at 09:53 +0800, arei.gonglei@huawei.com wrote:
> static uint64_t qdev_get_prop_mask64(Property *prop)
> {
> assert(prop->info == &qdev_prop_bit);
> - return 0x1 << prop->bitnr;
> + return 0x1ull << prop->bitnr;
> }
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
next prev parent reply other threads:[~2015-06-23 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 1:53 [Qemu-devel] [PATCH 0/2] fix two overflow problems arei.gonglei
2015-06-23 1:53 ` [Qemu-devel] [PATCH 1/2] virito-pci: fix OVERRUN problem arei.gonglei
2015-06-23 6:32 ` Michael S. Tsirkin
2015-06-23 7:01 ` Gonglei
2015-06-23 1:53 ` [Qemu-devel] [PATCH 2/2] qdev: fix OVERFLOW_BEFORE_WIDEN arei.gonglei
2015-06-23 7:37 ` Markus Armbruster
2015-06-23 7:48 ` Gerd Hoffmann [this message]
2015-06-23 5:53 ` [Qemu-devel] [PATCH 0/2] fix two overflow problems Michael S. Tsirkin
2015-06-23 7:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435045703.10077.47.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).