From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33185) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7jIG-0000mT-2e for qemu-devel@nongnu.org; Wed, 24 Jun 2015 07:56:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7jIB-0007gF-0W for qemu-devel@nongnu.org; Wed, 24 Jun 2015 07:56:40 -0400 From: Paolo Bonzini Date: Wed, 24 Jun 2015 13:56:31 +0200 Message-Id: <1435146991-305-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] hw: fix mask for ColdFire UART command register List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org The "miscellaneous commands" part of the register is 3 bits wide. Spotted by Coverity and confirmed in the datasheet, downloadable from http://cache.freescale.com/files/32bit/doc/ref_manual/MCF5307BUM.pdf (figure 14-6). Signed-off-by: Paolo Bonzini --- hw/char/mcf_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/char/mcf_uart.c b/hw/char/mcf_uart.c index 98fd44e..cda22ee 100644 --- a/hw/char/mcf_uart.c +++ b/hw/char/mcf_uart.c @@ -126,7 +126,7 @@ static void mcf_uart_do_tx(mcf_uart_state *s) static void mcf_do_command(mcf_uart_state *s, uint8_t cmd) { /* Misc command. */ - switch ((cmd >> 4) & 3) { + switch ((cmd >> 4) & 7) { case 0: /* No-op. */ break; case 1: /* Reset mode register pointer. */ -- 2.4.3