From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7n2M-0007QT-Iw for qemu-devel@nongnu.org; Wed, 24 Jun 2015 11:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z7n2J-0005UB-Bx for qemu-devel@nongnu.org; Wed, 24 Jun 2015 11:56:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z7n2J-0005Tw-6c for qemu-devel@nongnu.org; Wed, 24 Jun 2015 11:56:27 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6A805BC91A for ; Wed, 24 Jun 2015 15:56:26 +0000 (UTC) From: Thomas Huth Date: Wed, 24 Jun 2015 17:56:16 +0200 Message-Id: <1435161381-31521-1-git-send-email-thuth@redhat.com> Subject: [Qemu-devel] [PATCH 0/5] Network traffic dumping for -netdev, second try List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi , Jason Wang Cc: Markus Armbruster The "-net dump" option only works with the "-net" option. So far, it is not possible to dump network traffic with the "-netdev" option yet. This patch series now fixes this ugliness by enabling dumping for the "-netdev" option, too. Unlike with my first attempt a couple of weeks ago ("net: Enable vlans and dump for -netdev, too"), this patch series now does not "abuse" the disliked internal vlan hub infrastructure anymore but introduces a new, clean "dumpfile=xxx" option for the -netdev parameters instead. It's likely too late for version 2.4 for this patch series, but it would be great to get some review feedback for this anyway. Thomas Huth (5): net/dump: Add support for receive_iov function net/dump: Move DumpState into NetClientState net/dump: Rework net-dump init functions net/dump: Add dump option for netdev devices qemu options: Add information about dumpfile to help text include/net/net.h | 8 +++++ net/clients.h | 5 ++++ net/dump.c | 89 ++++++++++++++++++++++++++++++++++++------------------- net/net.c | 48 ++++++++++++++++++++++++++++++ qapi-schema.json | 12 ++++++-- qemu-options.hx | 26 +++++++++++----- 6 files changed, 147 insertions(+), 41 deletions(-) -- 1.8.3.1