* [Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups
@ 2015-06-25 13:48 Igor Mammedov
2015-06-26 9:11 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Igor Mammedov @ 2015-06-25 13:48 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, armbru
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
backends/hostmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/backends/hostmem.c b/backends/hostmem.c
index 4b5c53d..403be07 100644
--- a/backends/hostmem.c
+++ b/backends/hostmem.c
@@ -15,6 +15,7 @@
#include "qapi-visit.h"
#include "qemu/config-file.h"
#include "qom/object_interfaces.h"
+#include "qapi/qmp/qerror.h"
#ifdef CONFIG_NUMA
#include <numaif.h>
@@ -225,7 +226,7 @@ static void host_memory_backend_set_id(Object *obj, const char *id,
HostMemoryBackend *backend = MEMORY_BACKEND(obj);
if (backend->id) {
- error_set(errp, QERR_INVALID_PARAMETER_VALUE, "id",
+ error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "id",
"can't change already set value");
return;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups
2015-06-25 13:48 [Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups Igor Mammedov
@ 2015-06-26 9:11 ` Markus Armbruster
2015-06-26 9:36 ` Igor Mammedov
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2015-06-26 9:11 UTC (permalink / raw)
To: Igor Mammedov; +Cc: peter.maydell, qemu-devel
Igor Mammedov <imammedo@redhat.com> writes:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> backends/hostmem.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/backends/hostmem.c b/backends/hostmem.c
> index 4b5c53d..403be07 100644
> --- a/backends/hostmem.c
> +++ b/backends/hostmem.c
> @@ -15,6 +15,7 @@
> #include "qapi-visit.h"
> #include "qemu/config-file.h"
> #include "qom/object_interfaces.h"
> +#include "qapi/qmp/qerror.h"
>
> #ifdef CONFIG_NUMA
> #include <numaif.h>
> @@ -225,7 +226,7 @@ static void host_memory_backend_set_id(Object *obj, const char *id,
> HostMemoryBackend *backend = MEMORY_BACKEND(obj);
>
> if (backend->id) {
> - error_set(errp, QERR_INVALID_PARAMETER_VALUE, "id",
> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "id",
> "can't change already set value");
> return;
> }
I can't see this code in master or on the list.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups
2015-06-26 9:11 ` Markus Armbruster
@ 2015-06-26 9:36 ` Igor Mammedov
0 siblings, 0 replies; 3+ messages in thread
From: Igor Mammedov @ 2015-06-26 9:36 UTC (permalink / raw)
To: Markus Armbruster; +Cc: peter.maydell, qemu-devel
On Fri, 26 Jun 2015 11:11:16 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > backends/hostmem.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/backends/hostmem.c b/backends/hostmem.c
> > index 4b5c53d..403be07 100644
> > --- a/backends/hostmem.c
> > +++ b/backends/hostmem.c
> > @@ -15,6 +15,7 @@
> > #include "qapi-visit.h"
> > #include "qemu/config-file.h"
> > #include "qom/object_interfaces.h"
> > +#include "qapi/qmp/qerror.h"
> >
> > #ifdef CONFIG_NUMA
> > #include <numaif.h>
> > @@ -225,7 +226,7 @@ static void host_memory_backend_set_id(Object *obj, const char *id,
> > HostMemoryBackend *backend = MEMORY_BACKEND(obj);
> >
> > if (backend->id) {
> > - error_set(errp, QERR_INVALID_PARAMETER_VALUE, "id",
> > + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "id",
> > "can't change already set value");
> > return;
> > }
>
> I can't see this code in master or on the list.
>
true, my local tree seems to be in a weird state.
I've just cloned fresh tree and there isn't any error_set left in that file.
I'm sorry for noise.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-26 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-25 13:48 [Qemu-devel] [PATCH] hostmem: fix build failure caused by qerror cleanups Igor Mammedov
2015-06-26 9:11 ` Markus Armbruster
2015-06-26 9:36 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).