From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8BEK-0003tL-E0 for qemu-devel@nongnu.org; Thu, 25 Jun 2015 13:46:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8BEE-0007cU-KC for qemu-devel@nongnu.org; Thu, 25 Jun 2015 13:46:28 -0400 Received: from e18.ny.us.ibm.com ([129.33.205.208]:37190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8BEE-0007c8-Gf for qemu-devel@nongnu.org; Thu, 25 Jun 2015 13:46:22 -0400 Received: from /spool/local by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 25 Jun 2015 13:46:22 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 7E86A6E801D for ; Thu, 25 Jun 2015 13:38:05 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5PHkIik55050246 for ; Thu, 25 Jun 2015 17:46:19 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5PHkIsE002800 for ; Thu, 25 Jun 2015 13:46:18 -0400 From: "Jason J. Herne" Date: Thu, 25 Jun 2015 13:46:13 -0400 Message-Id: <1435254377-13322-2-git-send-email-jjherne@linux.vnet.ibm.com> In-Reply-To: <1435254377-13322-1-git-send-email-jjherne@linux.vnet.ibm.com> References: <1435254377-13322-1-git-send-email-jjherne@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v3 1/5] cpu: Provide vcpu throttling interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: afaerber@suse.de, amit.shah@redhat.com, dgilbert@redhat.com, borntraeger@de.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org Cc: "Jason J. Herne" Provide a method to throttle guest cpu execution. CPUState is augmented with timeout controls and throttle start/stop functions. To throttle the guest cpu the caller simply has to call the throttle set function and provide a percentage of throttle time. Signed-off-by: Jason J. Herne Reviewed-by: Matthew Rosato --- cpus.c | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/qom/cpu.h | 38 ++++++++++++++++++++++++++++ 2 files changed, 114 insertions(+) diff --git a/cpus.c b/cpus.c index de6469f..f57cf4f 100644 --- a/cpus.c +++ b/cpus.c @@ -68,6 +68,16 @@ static CPUState *next_cpu; int64_t max_delay; int64_t max_advance; +/* vcpu throttling controls */ +static QEMUTimer *throttle_timer; +static bool throttle_timer_stop; +static int throttle_percentage; +static float throttle_ratio; + +#define CPU_THROTTLE_PCT_MIN 1 +#define CPU_THROTTLE_PCT_MAX 99 +#define CPU_THROTTLE_TIMESLICE 10 + bool cpu_is_stopped(CPUState *cpu) { return cpu->stopped || !runstate_is_running(); @@ -919,6 +929,72 @@ static void qemu_kvm_wait_io_event(CPUState *cpu) qemu_wait_io_event_common(cpu); } +static void cpu_throttle_thread(void *opaque) +{ + long sleeptime_ms = (long)(throttle_ratio * CPU_THROTTLE_TIMESLICE); + + qemu_mutex_unlock_iothread(); + g_usleep(sleeptime_ms * 1000); /* Convert ms to us for usleep call */ + qemu_mutex_lock_iothread(); + + timer_mod(throttle_timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + + CPU_THROTTLE_TIMESLICE); +} + +static void cpu_throttle_timer_pop(void *opaque) +{ + CPUState *cpu; + + /* Stop the timer if needed */ + if (throttle_timer_stop) { + timer_del(throttle_timer); + timer_free(throttle_timer); + throttle_timer = NULL; + return; + } + + CPU_FOREACH(cpu) { + async_run_on_cpu(cpu, cpu_throttle_thread, NULL); + } +} + +void cpu_throttle_set(int new_throttle_pct) +{ + double pct; + + /* Ensure throttle percentage is within valid range */ + new_throttle_pct = MIN(new_throttle_pct, CPU_THROTTLE_PCT_MAX); + throttle_percentage = MAX(new_throttle_pct, CPU_THROTTLE_PCT_MIN); + + pct = (double)throttle_percentage/100; + throttle_ratio = pct / (1 - pct); + + if (!cpu_throttle_active()) { + throttle_timer_stop = false; + throttle_timer = timer_new_ms(QEMU_CLOCK_REALTIME, + cpu_throttle_timer_pop, NULL); + timer_mod(throttle_timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) + + CPU_THROTTLE_TIMESLICE); + } +} + +void cpu_throttle_stop(void) +{ + if (cpu_throttle_active()) { + throttle_timer_stop = true; + } +} + +bool cpu_throttle_active(void) +{ + return (throttle_timer != NULL); +} + +int cpu_throttle_get_percentage(void) +{ + return throttle_percentage; +} + static void *qemu_kvm_cpu_thread_fn(void *arg) { CPUState *cpu = arg; diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 39f0f19..56eb964 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -553,6 +553,44 @@ CPUState *qemu_get_cpu(int index); */ bool cpu_exists(int64_t id); +/** + * cpu_throttle_set: + * @new_throttle_pct: Percent of sleep time to running time. + * Valid range is 1 to 99. + * + * Throttles all vcpus by forcing them to sleep for the given percentage of + * time. A throttle_percentage of 50 corresponds to a 50% duty cycle roughly. + * (example: 10ms sleep for every 10ms awake). + * + * cpu_throttle_set can be called as needed to adjust new_throttle_pct. + * Once the throttling starts, it will remain in effect until cpu_throttle_stop + * is called. + */ +void cpu_throttle_set(int new_throttle_pct); + +/** + * cpu_throttle_stop: + * + * Stops the vcpu throttling started by cpu_throttle_set. + */ +void cpu_throttle_stop(void); + +/** + * cpu_throttle_active: + * + * Returns %true if the vcpus are currently being throttled, %false otherwise. + */ +bool cpu_throttle_active(void); + +/** + * cpu_throttle_get_percentage: + * + * Returns the vcpu throttle percentage. See cpu_throttle_set for details. + * + * Returns The throttle percentage in range 1 to 99. + */ +int cpu_throttle_get_percentage(void); + #ifndef CONFIG_USER_ONLY typedef void (*CPUInterruptHandler)(CPUState *, int); -- 1.9.1