From: gerg@uclinux.org
To: qemu-devel@nongnu.org
Cc: Greg Ungerer <gerg@uclinux.org>
Subject: [Qemu-devel] [PATCH 4/4] hw/net: fix mcf_fec driver receiver
Date: Fri, 26 Jun 2015 15:27:16 +1000 [thread overview]
Message-ID: <1435296436-12152-5-git-send-email-gerg@uclinux.org> (raw)
In-Reply-To: <1435296436-12152-1-git-send-email-gerg@uclinux.org>
From: Greg Ungerer <gerg@uclinux.org>
The network mcf_fec driver emulated receive side method is returning a
result of 0 causing the network layer to disable receive for this emulated
device. This results in the guest only ever receiving one packet.
Fix the recieve side processing to return the number of bytes that we
passed back through to the guest.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
hw/net/mcf_fec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c
index ea59017..e63af1b 100644
--- a/hw/net/mcf_fec.c
+++ b/hw/net/mcf_fec.c
@@ -413,6 +413,7 @@ static ssize_t mcf_fec_receive(NetClientState *nc, const uint8_t *buf, size_t si
uint32_t buf_addr;
uint8_t *crc_ptr;
unsigned int buf_len;
+ size_t retsize;
DPRINTF("do_rx len %d\n", size);
if (!s->rx_enabled) {
@@ -432,6 +433,7 @@ static ssize_t mcf_fec_receive(NetClientState *nc, const uint8_t *buf, size_t si
flags |= FEC_BD_LG;
}
addr = s->rx_descriptor;
+ retsize = size;
while (size > 0) {
mcf_fec_read_bd(&bd, addr);
if ((bd.flags & FEC_BD_E) == 0) {
@@ -476,7 +478,7 @@ static ssize_t mcf_fec_receive(NetClientState *nc, const uint8_t *buf, size_t si
s->rx_descriptor = addr;
mcf_fec_enable_rx(s);
mcf_fec_update(s);
- return size;
+ return retsize;
}
static const MemoryRegionOps mcf_fec_ops = {
--
1.9.1
next prev parent reply other threads:[~2015-06-26 5:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 5:27 [Qemu-devel] [PATCH 0/4] hw/net: fix m68/ColdFire ethernet fec support gerg
2015-06-26 5:27 ` [Qemu-devel] [PATCH 1/4] hw/net: create common collection of MII definitions gerg
2015-06-26 5:27 ` [Qemu-devel] [PATCH 2/4] hw/net: add ANLPAR bit definitions to generic mii gerg
2015-06-26 5:27 ` [Qemu-devel] [PATCH 3/4] hw/net: add simple phy support to mcf_fec driver gerg
2015-06-26 5:27 ` gerg [this message]
2015-06-26 10:12 ` [Qemu-devel] [PATCH 0/4] hw/net: fix m68/ColdFire ethernet fec support Stefan Hajnoczi
2015-06-26 12:07 ` Greg Ungerer
2015-06-30 5:38 ` Greg Ungerer
2015-07-27 13:11 ` Stefan Hajnoczi
2015-07-28 0:03 ` Greg Ungerer
2015-07-27 13:13 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435296436-12152-5-git-send-email-gerg@uclinux.org \
--to=gerg@uclinux.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).