From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9UJr-000268-Av for qemu-devel@nongnu.org; Mon, 29 Jun 2015 04:21:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9UJo-0003xI-09 for qemu-devel@nongnu.org; Mon, 29 Jun 2015 04:21:35 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:51504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9UJn-0003wa-Cv for qemu-devel@nongnu.org; Mon, 29 Jun 2015 04:21:31 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jun 2015 18:21:28 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 946F23578053 for ; Mon, 29 Jun 2015 18:21:26 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t5T8LFaH6553828 for ; Mon, 29 Jun 2015 18:21:23 +1000 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t5T8Kr36019188 for ; Mon, 29 Jun 2015 18:20:54 +1000 From: Bharata B Rao Date: Mon, 29 Jun 2015 13:50:24 +0530 Message-Id: <1435566027-17061-4-git-send-email-bharata@linux.vnet.ibm.com> In-Reply-To: <1435566027-17061-1-git-send-email-bharata@linux.vnet.ibm.com> References: <1435566027-17061-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH v4 3/6] pc: Abort if HotplugHandlerClass::plug() fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, imammedo@redhat.com, Bharata B Rao , ehabkost@redhat.com, david@gibson.dropbear.id.au HotplugHandlerClass::plug() shouldn't fail and hence use error_abort to abort if it fails. Signed-off-by: Bharata B Rao --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 8df1f3e..a66416d 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1577,7 +1577,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev, } hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev); - hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err); + hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &error_abort); out: error_propagate(errp, local_err); } -- 2.1.0