qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: seabios@seabios.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 14/18] virtio: add version 1.0 support to vp_find_vq
Date: Mon, 29 Jun 2015 10:53:36 +0200	[thread overview]
Message-ID: <1435568020-8669-15-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1435568020-8669-1-git-send-email-kraxel@redhat.com>

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 src/hw/virtio-pci.c | 61 +++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 47 insertions(+), 14 deletions(-)

diff --git a/src/hw/virtio-pci.c b/src/hw/virtio-pci.c
index 8097901..c80d38d 100644
--- a/src/hw/virtio-pci.c
+++ b/src/hw/virtio-pci.c
@@ -139,7 +139,6 @@ void vp_notify(struct vp_device *vp, struct vring_virtqueue *vq)
 int vp_find_vq(struct vp_device *vp, int queue_index,
                struct vring_virtqueue **p_vq)
 {
-   int ioaddr = GET_LOWFLAT(vp->ioaddr);
    u16 num;
 
    ASSERT32FLAT();
@@ -150,34 +149,49 @@ int vp_find_vq(struct vp_device *vp, int queue_index,
    }
    memset(vq, 0, sizeof(*vq));
 
+
    /* select the queue */
-
-   outw(queue_index, ioaddr + VIRTIO_PCI_QUEUE_SEL);
+   if (vp->use_modern) {
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_select, queue_index);
+   } else {
+       outw(queue_index, vp->ioaddr + VIRTIO_PCI_QUEUE_SEL);
+   }
 
    /* check if the queue is available */
-
-   num = inw(ioaddr + VIRTIO_PCI_QUEUE_NUM);
+   if (vp->use_modern) {
+       vp_modern_read(vp->common, virtio_pci_common_cfg,
+                      queue_size, num);
+       if (num > MAX_QUEUE_NUM) {
+           vp_modern_write(vp->common, virtio_pci_common_cfg,
+                           queue_size, MAX_QUEUE_NUM);
+           vp_modern_read(vp->common, virtio_pci_common_cfg,
+                          queue_size, num);
+       }
+   } else {
+       num = inw(vp->ioaddr + VIRTIO_PCI_QUEUE_NUM);
+   }
    if (!num) {
        dprintf(1, "ERROR: queue size is 0\n");
        goto fail;
    }
-
    if (num > MAX_QUEUE_NUM) {
        dprintf(1, "ERROR: queue size %d > %d\n", num, MAX_QUEUE_NUM);
        goto fail;
    }
 
    /* check if the queue is already active */
-
-   if (inl(ioaddr + VIRTIO_PCI_QUEUE_PFN)) {
-       dprintf(1, "ERROR: queue already active\n");
-       goto fail;
+   if (vp->use_modern) {
+       /* WIP */
+   } else {
+       if (inl(vp->ioaddr + VIRTIO_PCI_QUEUE_PFN)) {
+           dprintf(1, "ERROR: queue already active\n");
+           goto fail;
+       }
    }
-
    vq->queue_index = queue_index;
 
    /* initialize the queue */
-
    struct vring * vr = &vq->vring;
    vring_init(vr, num, (unsigned char*)&vq->queue);
 
@@ -186,8 +200,27 @@ int vp_find_vq(struct vp_device *vp, int queue_index,
     * NOTE: vr->desc is initialized by vring_init()
     */
 
-   outl((unsigned long)virt_to_phys(vr->desc) >> PAGE_SHIFT,
-        ioaddr + VIRTIO_PCI_QUEUE_PFN);
+   if (vp->use_modern) {
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_desc_lo, (unsigned long)virt_to_phys(vr->desc));
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_desc_hi, 0);
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_avail_lo, (unsigned long)virt_to_phys(vr->avail));
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_avail_hi, 0);
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_used_lo, (unsigned long)virt_to_phys(vr->used));
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_used_hi, 0);
+       vp_modern_write(vp->common, virtio_pci_common_cfg,
+                       queue_enable, 1);
+       vp_modern_read(vp->common, virtio_pci_common_cfg,
+                      queue_notify_off, vq->queue_notify_off);
+   } else {
+       outl((unsigned long)virt_to_phys(vr->desc) >> PAGE_SHIFT,
+            vp->ioaddr + VIRTIO_PCI_QUEUE_PFN);
+   }
 
    return num;
 
-- 
1.8.3.1

  parent reply	other threads:[~2015-06-29  8:54 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29  8:53 [Qemu-devel] [PATCH 00/18] virtio: add version 1.0 support Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 01/18] pci: allow to loop over capabilities Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 02/18] virtio: run drivers in 32bit mode Gerd Hoffmann
2015-07-03  6:45   ` Paolo Bonzini
2015-07-03  7:12     ` [Qemu-devel] [SeaBIOS] " Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 03/18] virtio: add struct vp_device Gerd Hoffmann
2015-06-29 12:48   ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2015-06-29 13:33     ` Gerd Hoffmann
2015-06-30  6:31       ` Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 04/18] virtio: pass struct pci_device to vp_init_simple Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 05/18] virtio: add version 1.0 structs and #defines Gerd Hoffmann
2015-06-29 13:19   ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2015-06-29 13:35     ` Gerd Hoffmann
2015-06-29 14:21       ` Kevin O'Connor
2015-06-29  8:53 ` [Qemu-devel] [PATCH 06/18] virtio: find version 1.0 virtio capabilities Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 07/18] virtio: add version 1.0 read/write macros Gerd Hoffmann
2015-06-29 13:02   ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2015-06-29 13:46     ` Gerd Hoffmann
2015-06-29 14:14       ` Kevin O'Connor
2015-06-29  8:53 ` [Qemu-devel] [PATCH 08/18] virtio: make features 64bit, support version 1.0 features Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 09/18] virtio: add version 1.0 support to vp_{get, set}_status Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 10/18] virtio: add version 1.0 support to vp_get_isr Gerd Hoffmann
2015-06-29 14:00   ` [Qemu-devel] [SeaBIOS] " Kevin O'Connor
2015-06-29 14:33     ` Gerd Hoffmann
2015-06-29 14:36       ` Kevin O'Connor
2015-06-29  8:53 ` [Qemu-devel] [PATCH 11/18] virtio: add version 1.0 support to vp_reset Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 12/18] virtio: add version 1.0 support to vp_notify Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 13/18] virtio: remove unused vp_del_vq Gerd Hoffmann
2015-06-29  8:53 ` Gerd Hoffmann [this message]
2015-06-29  8:53 ` [Qemu-devel] [PATCH 15/18] virtio-scsi: fix initialization for version 1.0 Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 16/18] virtio-blk: " Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 17/18] virtio: use version 1.0 if available (flip the big switch) Gerd Hoffmann
2015-06-29  8:53 ` [Qemu-devel] [PATCH 18/18] virtio: also probe version 1.0 pci ids Gerd Hoffmann
2015-06-29 14:26 ` [Qemu-devel] [SeaBIOS] [PATCH 00/18] virtio: add version 1.0 support Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435568020-8669-15-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).