From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9bFI-0004V0-7Y for qemu-devel@nongnu.org; Mon, 29 Jun 2015 11:45:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9bFD-00030g-LQ for qemu-devel@nongnu.org; Mon, 29 Jun 2015 11:45:20 -0400 Received: from smtp4-g21.free.fr ([212.27.42.4]:55042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9bFD-0002zE-FH for qemu-devel@nongnu.org; Mon, 29 Jun 2015 11:45:15 -0400 From: Laurent Vivier Date: Mon, 29 Jun 2015 17:44:56 +0200 Message-Id: <1435592698-25681-2-git-send-email-laurent@vivier.eu> In-Reply-To: <1435592698-25681-1-git-send-email-laurent@vivier.eu> References: <1435592698-25681-1-git-send-email-laurent@vivier.eu> Subject: [Qemu-devel] [PULL 1/3] m68k: is_mem is useless List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Laurent Vivier Remove is_mem as it is never tested anymore since: commit bfa50bc2638d877cf2900712b7503be22e8811cb Author: aliguori Date: Tue Nov 18 20:26:41 2008 +0000 Remove premature memop TB terminations (Jan Kiszka) Signed-off-by: Laurent Vivier Reviewed-by: Thomas Huth --- target-m68k/translate.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/target-m68k/translate.c b/target-m68k/translate.c index d6c478f..1f9b7fe 100644 --- a/target-m68k/translate.c +++ b/target-m68k/translate.c @@ -129,7 +129,6 @@ typedef struct DisasContext { uint32_t fpcr; struct TranslationBlock *tb; int singlestep_enabled; - int is_mem; TCGv_i64 mactmp; int done_mac; } DisasContext; @@ -179,7 +178,6 @@ static inline TCGv gen_load(DisasContext * s, int opsize, TCGv addr, int sign) { TCGv tmp; int index = IS_USER(s); - s->is_mem = 1; tmp = tcg_temp_new_i32(); switch(opsize) { case OS_BYTE: @@ -209,7 +207,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr) { TCGv_i64 tmp; int index = IS_USER(s); - s->is_mem = 1; tmp = tcg_temp_new_i64(); tcg_gen_qemu_ldf64(tmp, addr, index); gen_throws_exception = gen_last_qop; @@ -220,7 +217,6 @@ static inline TCGv_i64 gen_load64(DisasContext * s, TCGv addr) static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val) { int index = IS_USER(s); - s->is_mem = 1; switch(opsize) { case OS_BYTE: tcg_gen_qemu_st8(val, addr, index); @@ -241,7 +237,6 @@ static inline void gen_store(DisasContext *s, int opsize, TCGv addr, TCGv val) static inline void gen_store64(DisasContext *s, TCGv addr, TCGv_i64 val) { int index = IS_USER(s); - s->is_mem = 1; tcg_gen_qemu_stf64(val, addr, index); gen_throws_exception = gen_last_qop; } @@ -2227,7 +2222,6 @@ DISAS_INSN(fpu) mask = 0x80; for (i = 0; i < 8; i++) { if (ext & mask) { - s->is_mem = 1; dest = FREG(i, 0); if (ext & (1 << 13)) { /* store */ @@ -2999,7 +2993,6 @@ gen_intermediate_code_internal(M68kCPU *cpu, TranslationBlock *tb, dc->singlestep_enabled = cs->singlestep_enabled; dc->fpcr = env->fpcr; dc->user = (env->sr & SR_S) == 0; - dc->is_mem = 0; dc->done_mac = 0; lj = -1; num_insns = 0; -- 2.4.3