From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org,
qemu-devel@nongnu.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [Qemu-devel] [PATCH RFC 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure
Date: Mon, 29 Jun 2015 15:25:10 -0400 [thread overview]
Message-ID: <1435605913-23826-4-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1435605913-23826-1-git-send-email-konrad.wilk@oracle.com>
However the init routines assume that on errors the return
code is -1 (as the libxc API is) - while those xen_host_* routines follow
another paradigm - negative errno on return, 0 on success.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
hw/xen/xen_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 706e3d9..ea1ceda 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -716,7 +716,7 @@ static int xen_pt_initfn(PCIDevice *d)
/* Initialize virtualized PCI configuration (Extended 256 Bytes) */
if (xen_host_pci_get_block(&s->real_device, 0, d->config,
- PCI_CONFIG_SPACE_SIZE) == -1) {
+ PCI_CONFIG_SPACE_SIZE) < 0) {
xen_host_pci_device_put(&s->real_device);
return -1;
}
--
2.1.0
next prev parent reply other threads:[~2015-06-29 19:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 19:25 [Qemu-devel] [PATCH RFC v1] Cleanups + various fixes due to libxl ABI + more logging on errors Konrad Rzeszutek Wilk
2015-06-29 19:25 ` [Qemu-devel] [PATCH RFC 1/6] xen/pt: Update comments with proper function name Konrad Rzeszutek Wilk
2015-07-01 12:54 ` Stefano Stabellini
2015-06-29 19:25 ` [Qemu-devel] [PATCH RFC 2/6] xen/pt: Make xen_pt_msi_set_enable static Konrad Rzeszutek Wilk
2015-07-01 12:55 ` Stefano Stabellini
2015-06-29 19:25 ` Konrad Rzeszutek Wilk [this message]
2015-07-01 12:57 ` [Qemu-devel] [PATCH RFC 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure Stefano Stabellini
2015-06-29 19:25 ` [Qemu-devel] [PATCH RFC 4/6] xen: Print and use errno where applicable Konrad Rzeszutek Wilk
2015-07-01 13:01 ` Stefano Stabellini
2015-07-01 18:22 ` Konrad Rzeszutek Wilk
2015-07-02 11:00 ` Stefano Stabellini
2015-07-02 14:13 ` Konrad Rzeszutek Wilk
2015-06-29 19:25 ` [Qemu-devel] [PATCH RFC 5/6] xen/pt/msi: Add the register value when printing logging and error messages Konrad Rzeszutek Wilk
2015-06-29 19:25 ` [Qemu-devel] [PATCH RFC 6/6] xen: Add backtrace for serious issues Konrad Rzeszutek Wilk
2015-07-01 13:06 ` Stefano Stabellini
2015-07-02 13:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435605913-23826-4-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).