From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: jasowang@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive
Date: Tue, 30 Jun 2015 11:06:51 +0800 [thread overview]
Message-ID: <1435633611-14023-1-git-send-email-famz@redhat.com> (raw)
virtio_net_receive still does the check by calling
virtio_net_can_receive, if the device or driver is not ready, the packet
is dropped.
This is necessary because returning false from can_receive complicates
things: the peer would disable sending until we explicitly flush the
queue.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
hw/net/virtio-net.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index d728233..dbef0d0 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1503,7 +1503,6 @@ static int virtio_net_load_device(VirtIODevice *vdev, QEMUFile *f,
static NetClientInfo net_virtio_info = {
.type = NET_CLIENT_OPTIONS_KIND_NIC,
.size = sizeof(NICState),
- .can_receive = virtio_net_can_receive,
.receive = virtio_net_receive,
.link_status_changed = virtio_net_set_link_status,
.query_rx_filter = virtio_net_query_rxfilter,
--
2.4.4
next reply other threads:[~2015-06-30 3:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 3:06 Fam Zheng [this message]
2015-06-30 8:35 ` [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive Jason Wang
2015-07-02 12:46 ` Stefan Hajnoczi
2015-07-02 16:46 ` Michael S. Tsirkin
2015-07-03 1:12 ` Fam Zheng
2015-07-03 4:17 ` Fam Zheng
2015-07-04 18:48 ` Michael S. Tsirkin
2015-07-06 3:32 ` Jason Wang
2015-07-06 15:21 ` Stefan Hajnoczi
2015-07-06 17:09 ` Michael S. Tsirkin
2015-07-07 0:53 ` Fam Zheng
2015-07-07 8:10 ` Michael S. Tsirkin
2015-07-07 8:45 ` Jason Wang
2015-07-08 10:50 ` Stefan Hajnoczi
2015-07-13 4:52 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435633611-14023-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).