From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9p4b-0006x3-3K for qemu-devel@nongnu.org; Tue, 30 Jun 2015 02:31:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9p4W-0005PU-67 for qemu-devel@nongnu.org; Tue, 30 Jun 2015 02:31:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9p4W-0005PP-1F for qemu-devel@nongnu.org; Tue, 30 Jun 2015 02:31:08 -0400 Message-ID: <1435645864.30958.52.camel@redhat.com> From: Gerd Hoffmann Date: Tue, 30 Jun 2015 08:31:04 +0200 In-Reply-To: <1435584816.30958.13.camel@redhat.com> References: <1435568020-8669-1-git-send-email-kraxel@redhat.com> <1435568020-8669-4-git-send-email-kraxel@redhat.com> <20150629124823.GA30040@morn.localdomain> <1435584816.30958.13.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 03/18] virtio: add struct vp_device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: seabios@seabios.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" Hi, > > Is there a reason to make this a pointer as opposed to just placing > > the vp_device struct directly in struct virtiodrive_s? > > That'll work too, both blk and scsi have a struct where we can place > vp_device inside. I'll change it for v2. Oops, wrong. For virtio-blk it works, but for virtio-scsi all devices connected to the host adapter share one vp_device instance. And a per-hostadapter data structure doesn't exist because we don't need one. cheers, Gerd